Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932828AbcJRPlz (ORCPT ); Tue, 18 Oct 2016 11:41:55 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43176 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935562AbcJRPls (ORCPT ); Tue, 18 Oct 2016 11:41:48 -0400 Subject: Re: [PATCH 1/8] xen/x86: Remove PVH support To: Juergen Gross , david.vrabel@citrix.com References: <1476468318-24422-1-git-send-email-boris.ostrovsky@oracle.com> <1476468318-24422-2-git-send-email-boris.ostrovsky@oracle.com> <047c44cc-a932-024f-e069-d8620f8c3e8e@suse.com> <6ec04325-1e51-36c7-eeec-5e0352c4c34b@oracle.com> <8278b0a6-d114-9775-eb88-6292a9a2ab34@suse.com> Cc: roger.pau@citrix.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org From: Boris Ostrovsky Message-ID: <6bfab4fc-3576-3753-5660-861eda1153c1@oracle.com> Date: Tue, 18 Oct 2016 11:42:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <8278b0a6-d114-9775-eb88-6292a9a2ab34@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1664 Lines: 44 On 10/18/2016 11:33 AM, Juergen Gross wrote: > On 18/10/16 16:45, Boris Ostrovsky wrote: >> On 10/18/2016 09:46 AM, Juergen Gross wrote: >>> On 14/10/16 20:05, Boris Ostrovsky wrote: >>>> We are replacing existing PVH guests with new implementation. >>>> >>>> Signed-off-by: Boris Ostrovsky >>> Reviewed-by: Juergen Gross >>> >>> with the following addressed: >>> >>>> diff --git a/include/xen/xen.h b/include/xen/xen.h >>>> index f0f0252..d0f9684 100644 >>>> --- a/include/xen/xen.h >>>> +++ b/include/xen/xen.h >>>> @@ -29,17 +29,6 @@ enum xen_domain_type { >>>> #define xen_initial_domain() (0) >>>> #endif /* CONFIG_XEN_DOM0 */ >>>> >>>> -#ifdef CONFIG_XEN_PVH >>>> -/* This functionality exists only for x86. The XEN_PVHVM support exists >>>> - * only in x86 world - hence on ARM it will be always disabled. >>>> - * N.B. ARM guests are neither PV nor HVM nor PVHVM. >>>> - * It's a bit like PVH but is different also (it's further towards the H >>>> - * end of the spectrum than even PVH). >>>> - */ >>>> -#include >>>> -#define xen_pvh_domain() (xen_pv_domain() && \ >>>> - xen_feature(XENFEAT_auto_translated_physmap)) >>>> -#else >>>> #define xen_pvh_domain() (0) >>> Any reason you don't remove this, too (together with its last user in >>> arch/x86/xen/grant-table.c) ? >> grant-table.c is in fact one of the reasons: we will be using that code >> for PVHv2 again so I kept it to avoid unnecessary code churn. >> >> Also, we want to have a nop definition of xen_pvh_domain() for >> !CONFIG_XEN_PVH. > Okay, could you mention this in the commit message, please? Will do. -boris