Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938704AbcJRP6V (ORCPT ); Tue, 18 Oct 2016 11:58:21 -0400 Received: from mail-yw0-f176.google.com ([209.85.161.176]:35765 "EHLO mail-yw0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938660AbcJRP6F (ORCPT ); Tue, 18 Oct 2016 11:58:05 -0400 MIME-Version: 1.0 In-Reply-To: <1476771283-11398-3-git-send-email-wzz@rock-chips.com> References: <1476771283-11398-1-git-send-email-wzz@rock-chips.com> <1476771283-11398-3-git-send-email-wzz@rock-chips.com> From: Sean Paul Date: Tue, 18 Oct 2016 11:52:35 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/6] drm/bridge: remove dp init from analogix_dp_bind To: Zain Wang , Archit Cc: Daniel Vetter , Inki Dae , David Airlie , Tomeu Vizoso , Mika Kahola , =?UTF-8?Q?St=C3=A9phane_Marchesin?= , Tomasz Figa , Doug Anderson , Thierry Reding , Krzysztof Kozlowski , Heiko Stuebner , Jingoo Han , Javier Martinez Canillas , Linux Kernel Mailing List , dri-devel , linux-samsung-soc , linux-rockchip@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 40 On Tue, Oct 18, 2016 at 2:14 AM, Zain Wang wrote: > From: zain wang > > phy_power_on() and analogix_dp_init_dp would be called in bridge_eanble, > so remove them from analogix_dp_bind to be clear. > Reviewed-by: Sean Paul > Signed-off-by: zain wang > --- > > Changes in v3: > - remove changes before > - remove phy_power_on() and analogix_dp_init_dp from analogix_dp_bind(). > > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 001b075..bcae4dd 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1389,10 +1389,6 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, > > pm_runtime_enable(dev); > > - phy_power_on(dp->phy); > - > - analogix_dp_init_dp(dp); > - > ret = devm_request_threaded_irq(&pdev->dev, dp->irq, > analogix_dp_hardirq, > analogix_dp_irq_thread, > -- > 1.9.1 > >