Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030337AbcJRQDX (ORCPT ); Tue, 18 Oct 2016 12:03:23 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:35374 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964819AbcJRQDU (ORCPT ); Tue, 18 Oct 2016 12:03:20 -0400 Date: Tue, 18 Oct 2016 11:03:17 -0500 From: Rob Herring To: Neil Armstrong Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-oxnas@lists.tuxfamily.org, devicetree@vger.kernel.org Subject: Re: [RFC PATCH 1/3] ARM: dts: Add support for OX820 and Pogoplug V3 Message-ID: <20161018160317.dscfcbhkywmy3c37@rob-hp-laptop> References: <20161017124001.23820-1-narmstrong@baylibre.com> <20161017124001.23820-2-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017124001.23820-2-narmstrong@baylibre.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2743 Lines: 74 On Mon, Oct 17, 2016 at 02:39:59PM +0200, Neil Armstrong wrote: > Add device tree for the Oxford Seminconductor OX820 SoC and the > Cloud Engines PogoPlug v3 board. > Add the SoC and board compatible strings to oxnas bindings. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/arm/oxnas.txt | 5 + > arch/arm/boot/dts/Makefile | 3 +- > .../boot/dts/cloudengines-pogoplug-series-3.dts | 60 +++++ > arch/arm/boot/dts/ox820.dtsi | 259 +++++++++++++++++++++ > 4 files changed, 326 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/cloudengines-pogoplug-series-3.dts > create mode 100644 arch/arm/boot/dts/ox820.dtsi > > diff --git a/Documentation/devicetree/bindings/arm/oxnas.txt b/Documentation/devicetree/bindings/arm/oxnas.txt > index b9e4971..ac64e60 100644 > --- a/Documentation/devicetree/bindings/arm/oxnas.txt > +++ b/Documentation/devicetree/bindings/arm/oxnas.txt > @@ -5,5 +5,10 @@ Boards with the OX810SE SoC shall have the following properties: > Required root node property: > compatible: "oxsemi,ox810se" > > +Boards with the OX820 SoC shall have the following properties: > + Required root node property: > + compatible: "oxsemi,ox820" > + > Board compatible values: > - "wd,mbwe" (OX810SE) > + - "cloudengines,pogoplugv3" (OX820) > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index faacd52..5d9e8d5 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -588,7 +588,8 @@ dtb-$(CONFIG_ARCH_ORION5X) += \ > dtb-$(CONFIG_ARCH_PRIMA2) += \ > prima2-evb.dtb > dtb-$(CONFIG_ARCH_OXNAS) += \ > - wd-mbwe.dtb > + wd-mbwe.dtb \ > + cloudengines-pogoplug-series-3.dtb > dtb-$(CONFIG_ARCH_QCOM) += \ > qcom-apq8060-dragonboard.dtb \ > qcom-apq8064-arrow-sd-600eval.dtb \ > diff --git a/arch/arm/boot/dts/cloudengines-pogoplug-series-3.dts b/arch/arm/boot/dts/cloudengines-pogoplug-series-3.dts > new file mode 100644 > index 0000000..78d9149 > --- /dev/null > +++ b/arch/arm/boot/dts/cloudengines-pogoplug-series-3.dts > @@ -0,0 +1,60 @@ > +/* > + * cloudengines-pogoplug-series-3.dtsi - Device tree file for Cloud Engines PogoPlug Series 3 > + * > + * Copyright (C) 2016 Neil Armstrong > + * > + * Licensed under GPLv2 or later > + */ > + > +/dts-v1/; > +#include "ox820.dtsi" > + > +/ { > + model = "Cloud Engines PogoPlug Series 3"; > + > + compatible = "cloudengines,pogoplugv3", "oxsemi,ox820"; > + > + chosen { > + bootargs = "console=ttyS0,115200n8 earlyprintk=serial"; Use stdout-path and I don't think "earlyprintk=serial" is valid. With that, Acked-by: Rob Herring