Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034028AbcJRQIS (ORCPT ); Tue, 18 Oct 2016 12:08:18 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:56852 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030371AbcJRQII (ORCPT ); Tue, 18 Oct 2016 12:08:08 -0400 From: Punit Agrawal To: linux-acpi@vger.kernel.org, rjw@rjwysocki.net Cc: linux-kernel@vger.kernel.org, tbaicar@codeaurora.org, bp@suse.de, Punit Agrawal , Len Brown Subject: [PATCH] acpi/apei: Fix in-correct return value Date: Tue, 18 Oct 2016 17:07:19 +0100 Message-Id: <20161018160719.31252-1-punit.agrawal@arm.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 26 Although ghes_proc tests for error while reading the error status, it always return success (0). Fix this by propagating the return value. Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support") Signed-of-by: Punit Agrawal Cc: "Rafael J. Wysocki" Cc: Len Brown --- drivers/acpi/apei/ghes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index f0a029e..0d099a2 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes) ghes_do_proc(ghes, ghes->estatus); out: ghes_clear_estatus(ghes); - return 0; + return rc; } static void ghes_add_timer(struct ghes *ghes) -- 2.9.3