Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758533AbcJRQyI (ORCPT ); Tue, 18 Oct 2016 12:54:08 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:28336 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbcJRQyA (ORCPT ); Tue, 18 Oct 2016 12:54:00 -0400 Subject: Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results To: Julia Lawall References: Cc: mmarek@suse.com, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, lars@metafoo.de From: Vaishali Thakkar Message-ID: <58065376.5020406@oracle.com> Date: Tue, 18 Oct 2016 22:23:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 33 On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote: > I get the following in patch mode that I don't get in context mode: Hi, Are you getting same number of devm cases in your report for the context and patch mode? [except this case] > diff -u -p a/drivers/power/supply/tps65090-charger.c > b/drivers/power/supply/tps\ > 65090-charger.c > --- a/drivers/power/supply/tps65090-charger.c > +++ b/drivers/power/supply/tps65090-charger.c > @@ -311,7 +311,8 @@ static int tps65090_charger_probe(struct > > if (irq != -ENXIO) { > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > - tps65090_charger_isr, 0, "tps65090-charger", cdata); > + tps65090_charger_isr, IRQF_ONESHOT, > + "tps65090-charger", cdata); > if (ret) { > dev_err(cdata->dev, > "Unable to register irq %d err %d\n", irq, > > > julia > -- Vaishali