Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758533AbcJRRBM (ORCPT ); Tue, 18 Oct 2016 13:01:12 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:38615 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759538AbcJRRBF (ORCPT ); Tue, 18 Oct 2016 13:01:05 -0400 X-IronPort-AV: E=Sophos;i="5.31,362,1473112800"; d="scan'208";a="197261200" Date: Tue, 18 Oct 2016 19:01:01 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Vaishali Thakkar cc: Julia Lawall , mmarek@suse.com, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, lars@metafoo.de Subject: Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results In-Reply-To: <58065376.5020406@oracle.com> Message-ID: References: <58065376.5020406@oracle.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1835 Lines: 63 On Tue, 18 Oct 2016, Vaishali Thakkar wrote: > > > On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote: > > I get the following in patch mode that I don't get in context mode: > > Hi, > > Are you getting same number of devm cases in your report for the context > and patch mode? [except this case] The only devm case I get in context mode is: diff -u -p /var/linuxes/linux-next/drivers/acpi/evged.c /tmp/nothing/drivers/ac\ pi/evged.c --- /var/linuxes/linux-next/drivers/acpi/evged.c +++ /tmp/nothing/drivers/acpi/evged.c @@ -116,8 +116,6 @@ static acpi_status acpi_ged_request_inte if (r.flags & IORESOURCE_IRQ_SHAREABLE) irqflags |= IRQF_SHARED; - if (devm_request_threaded_irq(dev, irq, NULL, acpi_ged_irq_handler, - irqflags, "ACPI:Ged", event)) { dev_err(dev, "failed to setup event handler for irq %u\n", irq); return AE_ERROR; } This one has the property that the first argument is an identifier. The other cases seem to have a & expression. There are around 20 of them. julia > > > > diff -u -p a/drivers/power/supply/tps65090-charger.c > > b/drivers/power/supply/tps\ > > 65090-charger.c > > --- a/drivers/power/supply/tps65090-charger.c > > +++ b/drivers/power/supply/tps65090-charger.c > > @@ -311,7 +311,8 @@ static int tps65090_charger_probe(struct > > > > if (irq != -ENXIO) { > > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > > - tps65090_charger_isr, 0, "tps65090-charger", cdata); > > + tps65090_charger_isr, IRQF_ONESHOT, > > + "tps65090-charger", cdata); > > if (ret) { > > dev_err(cdata->dev, > > "Unable to register irq %d err %d\n", irq, > > > > > > julia > > > > -- > Vaishali >