Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760330AbcJRRMd (ORCPT ); Tue, 18 Oct 2016 13:12:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:43596 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300AbcJRRMZ (ORCPT ); Tue, 18 Oct 2016 13:12:25 -0400 Subject: Re: [PATCH v2 3/3] Coccinelle: misc: Add support for devm variant in all modes To: mmarek@suse.com References: <5ed1989baa292520d4ed674580ced775a1ec2707.1476635073.git.vaishali.thakkar@oracle.com> Cc: Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, lars@metafoo.de From: Vaishali Thakkar Message-ID: <58065552.8000605@oracle.com> Date: Tue, 18 Oct 2016 22:31:06 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5ed1989baa292520d4ed674580ced775a1ec2707.1476635073.git.vaishali.thakkar@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1690 Lines: 67 On Sunday 16 October 2016 10:37 PM, Vaishali Thakkar wrote: > Add missing support for the devm_request_threaded_irq in > the rules of context, report and org modes. > > Misc: > ---- > To be consistent with other scripts, change confidence level > of the script to 'Moderate'. > > Signed-off-by: Vaishali Thakkar > --- > scripts/coccinelle/misc/irqf_oneshot.cocci | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci > index 03b748d..f6c93fd 100644 > --- a/scripts/coccinelle/misc/irqf_oneshot.cocci > +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci > @@ -5,7 +5,7 @@ > /// So pass the IRQF_ONESHOT flag in this case. > /// > // > -// Confidence: Good > +// Confidence: Moderate > // Comments: > // Options: --no-includes > > @@ -89,13 +89,21 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, > @depends on context@ > position p != {r1.p,r2.p}; > @@ > +( > *request_threaded_irq@p(irq, NULL, ...) > +| > +*devm_request_threaded_irq@p(dev, irq, NULL, ...) > +) > > @match depends on report || org@ > expression irq; > position p != {r1.p,r2.p}; > @@ > +( > request_threaded_irq@p(irq, NULL, ...) > +| > +devm_request_threaded_irq@p(dev, irq, NULL, ...) > +) Oh, my bad here. :( Forgot the initialization of meta variables for the arguments. But I am wondering why coccicheck didn't fail here. Isn't it suppose to give parsing errors? Or it doesn't do that? In any case, I am sorry for this. I'll send the revised version of the patches. > @script:python depends on org@ > p << match.p; > -- Vaishali