Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760593AbcJRROr (ORCPT ); Tue, 18 Oct 2016 13:14:47 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:49899 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756000AbcJRROj (ORCPT ); Tue, 18 Oct 2016 13:14:39 -0400 Subject: Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results To: Julia Lawall References: <58065376.5020406@oracle.com> Cc: mmarek@suse.com, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, lars@metafoo.de From: Vaishali Thakkar Message-ID: <580657CB.3000200@oracle.com> Date: Tue, 18 Oct 2016 22:41:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2321 Lines: 75 On Tuesday 18 October 2016 10:31 PM, Julia Lawall wrote: > > > On Tue, 18 Oct 2016, Vaishali Thakkar wrote: > >> >> >> On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote: >>> I get the following in patch mode that I don't get in context mode: >> >> Hi, >> >> Are you getting same number of devm cases in your report for the context >> and patch mode? [except this case] > > The only devm case I get in context mode is: > > diff -u -p /var/linuxes/linux-next/drivers/acpi/evged.c > /tmp/nothing/drivers/ac\ > pi/evged.c > --- /var/linuxes/linux-next/drivers/acpi/evged.c > +++ /tmp/nothing/drivers/acpi/evged.c > @@ -116,8 +116,6 @@ static acpi_status acpi_ged_request_inte > if (r.flags & IORESOURCE_IRQ_SHAREABLE) > irqflags |= IRQF_SHARED; > > - if (devm_request_threaded_irq(dev, irq, NULL, acpi_ged_irq_handler, > - irqflags, "ACPI:Ged", event)) { > dev_err(dev, "failed to setup event handler for irq %u\n", irq); > return AE_ERROR; > } > > This one has the property that the first argument is an identifier. The > other cases seem to have a & expression. There are around 20 of them. Although I got the issue with the patches, I am wondering why even context mode gave result for the identifiers even though they are not initialized? Does that mean it automatically assumes the type of meta variables even though they are not initialized? I think spatch gives warnings for such cases. But I am not sure about the coccicheck. > julia > > > >> >> >>> diff -u -p a/drivers/power/supply/tps65090-charger.c >>> b/drivers/power/supply/tps\ >>> 65090-charger.c >>> --- a/drivers/power/supply/tps65090-charger.c >>> +++ b/drivers/power/supply/tps65090-charger.c >>> @@ -311,7 +311,8 @@ static int tps65090_charger_probe(struct >>> >>> if (irq != -ENXIO) { >>> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, >>> - tps65090_charger_isr, 0, "tps65090-charger", cdata); >>> + tps65090_charger_isr, IRQF_ONESHOT, >>> + "tps65090-charger", cdata); >>> if (ret) { >>> dev_err(cdata->dev, >>> "Unable to register irq %d err %d\n", irq, >>> >>> >>> julia >>> >> >> -- >> Vaishali >> -- Vaishali