Subject: Re: [PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument
 type
To: Ryan Swan <ryan@ryanswan.com>, devel@driverdev.osuosl.org
References: <1476813811-22988-1-git-send-email-ryan@ryanswan.com>
Cc: liodot@gmail.com, charrer@alacritech.com, gregkh@linuxfoundation.org,
        bmarsh94@gmail.com, amarjargal.gundjalam@gmail.com, aquannie@gmail.com,
        janani.rvchndrn@gmail.com, kevin.m.wern@gmail.com,
        linux-kernel@vger.kernel.org
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <2d4bd18f-1e31-e62e-6ae4-d544bae933cd@gmx.de>
Date: Tue, 18 Oct 2016 21:22:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1476813811-22988-1-git-send-email-ryan@ryanswan.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1145
Lines: 35

Hi Ryan,

On 18.10.2016 20:03, Ryan Swan wrote:
> sparse produced
> warning: incorrect type in argument 2 (different address spaces)
> expected void const volatile [noderef] <asn:2>*src
> got struct slic_stats *stats
> 
> casting argument 2 to what is expected by memcpy_fromio() fixed this
> 
> Signed-off-by: Ryan Swan <ryan@ryanswan.com>
> ---
>  drivers/staging/slicoss/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 2802b90..7c6feb1 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
>  		if (stats->rcv_drops > old->rcv_drops)
>  			adapter->rcv_drops += (stats->rcv_drops -
>  					       old->rcv_drops);
> -		memcpy_fromio(old, stats, sizeof(*stats));
> +		memcpy_fromio(old, (void __iomem *)stats, sizeof(*stats));
>  		break;
>  	}
>  	case SLIC_UPR_RLSR:
> 

The issue here is the use of memcpy_fromio() while it actually is not io but dma 
memory that we copy from.

Regards,
Lino