Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756591AbcJRUJP (ORCPT ); Tue, 18 Oct 2016 16:09:15 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:33954 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbcJRUJH (ORCPT ); Tue, 18 Oct 2016 16:09:07 -0400 Subject: Re: [PATCH 1/2] mmc: sdhci-iproc: Add brcm,sdhci-iproc compat string in bindings document To: Rob Herring References: <1476297352-7812-1-git-send-email-scott.branden@broadcom.com> <1476297352-7812-2-git-send-email-scott.branden@broadcom.com> <20161018131614.lskxbdir3ghun5md@rob-hp-laptop> Cc: Ulf Hansson , Mark Rutland , Ray Jui , Scott Branden , Adrian Hunter , BCM Kernel Feedback , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel From: Scott Branden Message-ID: <93502f42-ae86-742f-a8b1-3645005fa98e@broadcom.com> Date: Tue, 18 Oct 2016 13:08:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161018131614.lskxbdir3ghun5md@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 33 Hi Rob, On 16-10-18 06:16 AM, Rob Herring wrote: > On Wed, Oct 12, 2016 at 11:35:51AM -0700, Scott Branden wrote: >> Adds brcm,sdhci-iproc compat string to DT bindings document for >> the iProc SDHCI driver. >> >> Signed-off-by: Anup Patel >> Signed-off-by: Scott Branden >> --- >> Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >> index be56d2b..aa58b94 100644 >> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >> @@ -7,6 +7,7 @@ Required properties: >> - compatible : Should be one of the following >> "brcm,bcm2835-sdhci" >> "brcm,sdhci-iproc-cygnus" >> + "brcm,sdhci-iproc" > > Seems kind of generic. SoC specific compatible strings please. > The compatibility string is generic on purpose as it is not intended to be SoC specific but work on all new iproc SoCs that have the proper fixes in place for this block (unlike bcm2835 and cygnus class devices which can only do 32-bit accesses). I could call it brcm,sdhci-iproc-v2 if that is better or leave it as is. Please let me know your preferences. Regards, Scott