Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756817AbcJRUTW (ORCPT ); Tue, 18 Oct 2016 16:19:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44270 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbcJRUTO (ORCPT ); Tue, 18 Oct 2016 16:19:14 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 18 Oct 2016 13:19:13 -0700 From: Subhash Jadavani To: Vivek Gautam Cc: kishon@ti.com, jejb@linux.vnet.ibm.com, vinholikatti@gmail.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-scsi-owner@vger.kernel.org Subject: Re: [PATCH v2 09/10] scsi/ufs: qcom: Add phy_exit call in hcd exit path In-Reply-To: <1476800897-19898-10-git-send-email-vivek.gautam@codeaurora.org> References: <1476800897-19898-1-git-send-email-vivek.gautam@codeaurora.org> <1476800897-19898-10-git-send-email-vivek.gautam@codeaurora.org> Message-ID: <1b0a9e1ebeef74f9ead7c7b71282c86d@codeaurora.org> User-Agent: Roundcube Webmail/1.2.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 32 On 2016-10-18 07:28, Vivek Gautam wrote: > Do a phy_exit() over the ufs phy in the ufs qcom exit path > to de-initialize the phy. > > Signed-off-by: Vivek Gautam > --- > > New patch added in v2 series. > > drivers/scsi/ufs/ufs-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index 6e4ce5f..dfd2af8 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -1272,6 +1272,7 @@ static void ufs_qcom_exit(struct ufs_hba *hba) > > ufs_qcom_disable_lane_clks(host); > phy_power_off(host->generic_phy); > + phy_exit(host->generic_phy); > } > > static int ufs_qcom_set_dme_vs_core_clk_ctrl_clear_div(struct ufs_hba > *hba, LGTM. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project