Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933883AbcJRUjR (ORCPT ); Tue, 18 Oct 2016 16:39:17 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34379 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932511AbcJRUjH (ORCPT ); Tue, 18 Oct 2016 16:39:07 -0400 Subject: Re: [PATCH v2] arm64: defconfig: enable EEPROM_AT25 config option To: Olof Johansson References: <1476298306-9138-1-git-send-email-scott.branden@broadcom.com> <207706e2-8fd4-748f-2ee7-3c372b447a7d@broadcom.com> Cc: Catalin Marinas , Will Deacon , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BCM Kernel Feedback From: Scott Branden Message-ID: <89501c0e-b544-8d5c-a158-7a3484af935d@broadcom.com> Date: Tue, 18 Oct 2016 13:38:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1635 Lines: 50 Hi Olof, On 16-10-17 05:04 PM, Olof Johansson wrote: > On Mon, Oct 17, 2016 at 4:24 PM, Scott Branden > wrote: >> Hi Olof, >> >> On 16-10-17 02:58 PM, Olof Johansson wrote: >>> >>> Hi, >>> >>> On Wed, Oct 12, 2016 at 11:51 AM, Scott Branden >>> wrote: >>>> >>>> Enable support for on board SPI EEPROM by turning on >>>> CONFIG_EEPROM_AT25. This needs to be on in order to >>>> boot and test the kernel with a static rootfs image >>>> that is not rebuilt everytime the kernel is rebuilt. >>> >>> >>> If we did this for every kernel option we'd get a huge kernel. >>> >>> In general, we've said that static options for what's needed to boot >>> to rootfs (i.e. storage and network drivers for nfsroot) are fine to >>> enable statically. >>> >>> I doubt you need the EEPROM driver to boot to rootfs on your system, >>> so please enable it as a module instead. OK, I will upstream as module and need config fragments maintained locally in order to test defconfig on our test setup. >>> >>> Look into using config fragments in case you need to modify the >>> options for local builds, it should be a convenient way to have a >>> small delta to apply to fit your internal needs, instead of completely >>> forking the config file. >> >> >> Do you allow such config fragments to be upstreamed or do we need to >> maintain these in our tree? > > There's no place for them upstream. Maintain locally or in a separate repo. If that is the case - shall we cleanup arch/arm/configs and delete dram_0x00000000.config that was introduced in the 4.4 kernel? > > > -Olof > Thanks, Scott