Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936119AbcJRV04 (ORCPT ); Tue, 18 Oct 2016 17:26:56 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33864 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754532AbcJRV0s (ORCPT ); Tue, 18 Oct 2016 17:26:48 -0400 From: Ryan Swan To: devel@driverdev.osuosl.org Cc: Ryan Swan , liodot@gmail.com, charrer@alacritech.com, gregkh@linuxfoundation.org, LinoSanfilippo@gmx.de, bmarsh94@gmail.com, amarjargal.gundjalam@gmail.com, aquannie@gmail.com, janani.rvchndrn@gmail.com, kevin.m.wern@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH] staging: slicoss: replace memcpy_fromio with memcpy Date: Tue, 18 Oct 2016 17:26:43 -0400 Message-Id: <1476826003-1202-1-git-send-email-ryan@ryanswan.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 24 As per discusion with Lino Sanfilippo, memcpy is the proper way to copy across dma memory, which also removes sparse warning that triggered inquiry. Signed-off-by: Ryan Swan --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 2802b90..9a1dc72 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr) if (stats->rcv_drops > old->rcv_drops) adapter->rcv_drops += (stats->rcv_drops - old->rcv_drops); - memcpy_fromio(old, stats, sizeof(*stats)); + memcpy(old, stats, sizeof(*stats)); break; } case SLIC_UPR_RLSR: -- 2.7.4