Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754340AbcJSFas (ORCPT ); Wed, 19 Oct 2016 01:30:48 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:32848 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbcJSFai (ORCPT ); Wed, 19 Oct 2016 01:30:38 -0400 MIME-Version: 1.0 In-Reply-To: <20161017153125.GD23255@localhost> References: <1476611954-11318-1-git-send-email-pankaj.bharadiya@gmail.com> <20161017153125.GD23255@localhost> From: Vaibhav Agarwal Date: Wed, 19 Oct 2016 11:00:17 +0530 Message-ID: Subject: Re: [PATCH] staging: greybus: audio: Rename cport with intf_id To: Johan Hovold Cc: Pankaj Bharadiya , Greg Kroah-Hartman , Mark Greer , Alex Elder , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 30 On Mon, Oct 17, 2016 at 9:01 PM, Johan Hovold wrote: > On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote: >> gb_audio_manager_module_descriptor's cport field is actually used to >> manage and pass interface id to user space. >> >> Thus rename gb_audio_manager_module_descriptor's 'cport' field and >> few other things to avoid confusion. > > Please be more specific about what these other things are; in this case > sysfs attributes, uevent vars, and an odd-looking sysfs-string > interface (more?). > > Wouldn't this change break any current user-space implementation? Yes, it would require changes in user space code as well. For now, it should be GMP-Audio HAL only. > > Also why aren't any of these attributes documented as they should be? Currently, none of GB Audio specific sysfs entries are documented. I'll share another patch for this. -- thanks, ./va > > Thanks, > Johan