Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149AbcJSFvd convert rfc822-to-8bit (ORCPT ); Wed, 19 Oct 2016 01:51:33 -0400 Received: from mail.kernel.org ([198.145.29.136]:45966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbcJSFv2 (ORCPT ); Wed, 19 Oct 2016 01:51:28 -0400 MIME-Version: 1.0 In-Reply-To: <58DB0A67-6C74-409B-80B2-9F02492D3A55@soulik.info> References: <1476811129-4450-1-git-send-email-ayaka@soulik.info> <1476811129-4450-3-git-send-email-ayaka@soulik.info> <20161018173748.GB30003@kozik-lap> <58DB0A67-6C74-409B-80B2-9F02492D3A55@soulik.info> From: Krzysztof Kozlowski Date: Wed, 19 Oct 2016 08:51:24 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v9 2/2] ARM: dts: add TOPEET itop elite based board To: Ayaka Cc: devicetree@vger.kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 33 On Wed, Oct 19, 2016 at 4:15 AM, Ayaka wrote: > > > 從我的 iPad 傳送 > >> Krzysztof Kozlowski 於 2016年10月19日 上午1:37 寫道： >> >>> On Wed, Oct 19, 2016 at 01:18:49AM +0800, Randy Li wrote: >>> The TOPEET itop exynos 4412 have three versions base board. The >>> Elite version is the cheap one without too much peripheral devices >>> on it. >>> >>> Currently supported are serial console, wired networking(USB), >>> USB OTG in peripheral mode, USB host, SD storage, GPIO buttons, >>> PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also >>> enabled. >>> >>> The FIMC is not used for camera currently, I enabled it just for a >>> colorspace converter. >>> >>> Signed-off-by: Randy Li >>> Reviewed-by: Krzysztof Kozlowski >> >> Thanks, applied, with missing Rob's ack, minor changes in commit msg and >> fix in pin function (you used macro for pull up/down instead of >> function). > The last time I saw the other dts have applied that, but they are not now. A header file is also missed reported by kbuild, but I didn't meet that. I wonder why I didn't encounter the build error on my machine... This needs a follow up fix. Best regards, Krzysztof