MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 8BIT
Message-id: <580746E2.5080800@samsung.com>
Date: Wed, 19 Oct 2016 19:11:46 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.6.0
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] extcon: qcom-spmi-misc: Sync the extcon state on interrupt
References: <CGME20161018001726epcas1p338c9fc5887017571f8a3fd954e0ae216@epcas1p3.samsung.com>
 <20161018001602.18617-1-stephen.boyd@linaro.org>
In-reply-to: <20161018001602.18617-1-stephen.boyd@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1277
Lines: 35

Hi Stephen,

On 2016년 10월 18일 09:16, Stephen Boyd wrote:
> The driver was changed after submission to use the new style APIs
> like extcon_set_state(). Unfortunately, that only sets the state,
> and doesn't notify any consumers that the cable state has
> changed. Use extcon_set_state_sync() here instead so that we
> notify cable consumers of the state change. This fixes USB
> host-device role switching on the db8074 platform.
> 
> Fixes: 38085c987f52 ("extcon: Add support for qcom SPMI PMIC USB id detection hardware")
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
>  drivers/extcon/extcon-qcom-spmi-misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon-qcom-spmi-misc.c
> index ca957a5f4291..b8cde096a808 100644
> --- a/drivers/extcon/extcon-qcom-spmi-misc.c
> +++ b/drivers/extcon/extcon-qcom-spmi-misc.c
> @@ -51,7 +51,7 @@ static void qcom_usb_extcon_detect_cable(struct work_struct *work)
>  	if (ret)
>  		return;
>  
> -	extcon_set_state(info->edev, EXTCON_USB_HOST, !id);
> +	extcon_set_state_sync(info->edev, EXTCON_USB_HOST, !id);
>  }
>  
>  static irqreturn_t qcom_usb_irq_handler(int irq, void *dev_id)
> 

Applied it.

Best Regards,
Chanwoo Choi