Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756777AbcJSOXe (ORCPT ); Wed, 19 Oct 2016 10:23:34 -0400 Received: from mail-qk0-f179.google.com ([209.85.220.179]:36763 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756227AbcJSOXb (ORCPT ); Wed, 19 Oct 2016 10:23:31 -0400 Date: Wed, 19 Oct 2016 10:23:26 -0400 From: Jarod Wilson To: Haiyang Zhang Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , KY Srinivasan , "Michael S. Tsirkin" , Shrikrishna Khare , "VMware, Inc." Subject: Re: [PATCH net-next 5/6] net: use core MTU range checking in virt drivers Message-ID: <20161019142326.GD18569@redhat.com> References: <20161019023333.15760-1-jarod@redhat.com> <20161019023333.15760-6-jarod@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2684 Lines: 83 On Wed, Oct 19, 2016 at 02:07:47PM +0000, Haiyang Zhang wrote: > > > > -----Original Message----- > > From: Jarod Wilson [mailto:jarod@redhat.com] > > Sent: Tuesday, October 18, 2016 10:34 PM > > To: linux-kernel@vger.kernel.org > > Cc: Jarod Wilson ; netdev@vger.kernel.org; > > virtualization@lists.linux-foundation.org; KY Srinivasan > > ; Haiyang Zhang ; Michael S. > > Tsirkin ; Shrikrishna Khare ; VMware, > > Inc. > > Subject: [PATCH net-next 5/6] net: use core MTU range checking in virt > > drivers > > > > hyperv_net: > > - set min/max_mtu > > > > virtio_net: > > - set min/max_mtu > > - remove virtnet_change_mtu > > > > vmxnet3: > > - set min/max_mtu > > > > CC: netdev@vger.kernel.org > > CC: virtualization@lists.linux-foundation.org > > CC: "K. Y. Srinivasan" > > CC: Haiyang Zhang > > CC: "Michael S. Tsirkin" > > CC: Shrikrishna Khare > > CC: "VMware, Inc." > > Signed-off-by: Jarod Wilson > > --- > > drivers/net/hyperv/hyperv_net.h | 4 ++-- > > drivers/net/hyperv/netvsc_drv.c | 14 +++++++------- > > drivers/net/virtio_net.c | 23 ++++++++++------------- > > drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++++--- > > 4 files changed, 23 insertions(+), 25 deletions(-) > > > > diff --git a/drivers/net/hyperv/hyperv_net.h > > b/drivers/net/hyperv/hyperv_net.h > > index f4fbcb5..3958ada 100644 > > --- a/drivers/net/hyperv/hyperv_net.h > > +++ b/drivers/net/hyperv/hyperv_net.h > > @@ -606,8 +606,8 @@ struct nvsp_message { > > } __packed; > > > > > > -#define NETVSC_MTU 65536 > > -#define NETVSC_MTU_MIN 68 > > +#define NETVSC_MTU 65535 > > Why change it to 65535? For Hyperv host, this should be 65536. Forgot to call this change out, sorry. That was changed, because of IP_MAX_MTU being 0xFFFFU -> 65535. > > @@ -1343,6 +1336,13 @@ static int netvsc_probe(struct hv_device *dev, > > > > netif_carrier_off(net); > > > > + /* MTU range: 68 - 1500 or 65521 */ > > + net->min_mtu = NETVSC_MTU_MIN; > > + if (nvdev->nvsp_version >= NVSP_PROTOCOL_VERSION_2) > > + net->max_mtu = NETVSC_MTU - ETH_HLEN; > > + else > > + net->max_mtu = ETH_DATA_LEN; > > + > > netvsc_init_settings(net); > > > > net_device_ctx = netdev_priv(net); > > nvdev->nvsp_version is not set until after rndis_filter_device_add() > is successfully completed. > You need to move this part to the place just before this line: > ret = register_netdev(net); Okay, will fix that up. -- Jarod Wilson jarod@redhat.com