Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942512AbcJSOcX (ORCPT ); Wed, 19 Oct 2016 10:32:23 -0400 Received: from mail-qk0-f171.google.com ([209.85.220.171]:35391 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942157AbcJSOcT (ORCPT ); Wed, 19 Oct 2016 10:32:19 -0400 MIME-Version: 1.0 In-Reply-To: <57F64D0B.5050506@math.uni-bielefeld.de> References: <1470850236-9101-1-git-send-email-shuahkh@osg.samsung.com> <57F64D0B.5050506@math.uni-bielefeld.de> From: Inki Dae Date: Wed, 19 Oct 2016 22:28:40 +0900 Message-ID: Subject: Re: [PATCH] exynos-drm: Fix error messages to print flags and size To: Tobias Jakobi Cc: Shuah Khan , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Dave Airlie , Kukjin Kim , Krzysztof Kozlowski , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , DRI mailing list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1487 Lines: 49 2016-10-06 22:09 GMT+09:00 Tobias Jakobi : > Hello, > > I think this patch was never picked up. So just a short 'ping' from my side. > Oops. one I missed. Will pick it up soon. Thanks, Inki Dae > With best wishes, > Tobias > > > Shuah Khan wrote: >> Fix exynos_drm_gem_create() error messages to include flags and size when >> flags and size are invalid. >> >> Signed-off-by: Shuah Khan >> --- >> drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c >> index cdf9f1a..4c4cb0e 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c >> @@ -231,12 +231,12 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev, >> int ret; >> >> if (flags & ~(EXYNOS_BO_MASK)) { >> - DRM_ERROR("invalid flags.\n"); >> + DRM_ERROR("invalid GEM buffer flags: %u\n", flags); >> return ERR_PTR(-EINVAL); >> } >> >> if (!size) { >> - DRM_ERROR("invalid size.\n"); >> + DRM_ERROR("invalid GEM buffer size: %lu\n", size); >> return ERR_PTR(-EINVAL); >> } >> >> > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel