Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943652AbcJSO5z (ORCPT ); Wed, 19 Oct 2016 10:57:55 -0400 Received: from userp1050.oracle.com ([156.151.31.82]:17849 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941358AbcJSO5u (ORCPT ); Wed, 19 Oct 2016 10:57:50 -0400 Date: Wed, 19 Oct 2016 10:40:32 +0300 From: Dan Carpenter To: Giuseppe Cavallaro Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, Alexandre TORGUE , Rayagond Kokatanur , Nicolas Pitre Subject: Re: [PATCH (net.git)] stmmac: fix and review the ptp registration. Message-ID: <20161019074032.GD4418@mwanda> References: <1476860801-28242-1-git-send-email-peppe.cavallaro@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476860801-28242-1-git-send-email-peppe.cavallaro@st.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 213 Lines: 6 Looks good. This actually fixes my commit where I changed the return PTR_ERR(NULL) which means success to PTR_ERR(-ESOMETHING). Unintentionally returning success was the correct behavior. regards, dan carpenter