Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944006AbcJSPEY (ORCPT ); Wed, 19 Oct 2016 11:04:24 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:35954 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943265AbcJSPEV (ORCPT ); Wed, 19 Oct 2016 11:04:21 -0400 Subject: Re: [PATCH v2] hwrng: meson: Fix module autoload for OF registration To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1476733877-20275-1-git-send-email-javier@osg.samsung.com> Cc: Jason Gunthorpe , Kevin Hilman , PrasannaKumar Muralidharan , Carlo Caione , linux-amlogic@lists.infradead.org, Herbert Xu , Matt Mackall , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: Date: Wed, 19 Oct 2016 11:19:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476733877-20275-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 44 On 10/17/2016 09:51 PM, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias > alias: platform:meson-rng > > After this patch: > > $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias > alias: platform:meson-rng > alias: of:N*T*Camlogic,meson-rngC* > alias: of:N*T*Camlogic,meson-rng > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v2: > - Remove unrelated changes added by mistake. Suggested by Jason Gunthorpe. > > drivers/char/hw_random/meson-rng.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c > index 58bef39f7286..51864a509be7 100644 > --- a/drivers/char/hw_random/meson-rng.c > +++ b/drivers/char/hw_random/meson-rng.c > @@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = { > { .compatible = "amlogic,meson-rng", }, > {}, > }; > +MODULE_DEVICE_TABLE(of, meson_rng_of_match); > > static struct platform_driver meson_rng_driver = { > .probe = meson_rng_probe, > Acked-by: Neil Armstrong