Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944601AbcJSPPv (ORCPT ); Wed, 19 Oct 2016 11:15:51 -0400 Received: from mail-db5eur01on0069.outbound.protection.outlook.com ([104.47.2.69]:15117 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S943886AbcJSPPp (ORCPT ); Wed, 19 Oct 2016 11:15:45 -0400 From: "Y.B. Lu" To: Ulf Hansson , Scott Wood , "Arnd Bergmann" CC: linux-mmc , "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-clk , "linux-i2c@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "netdev@vger.kernel.org" , Mark Rutland , Rob Herring , Russell King , Jochen Friedrich , Joerg Roedel , Claudiu Manoil , "Bhupesh Sharma" , Qiang Zhao , Kumar Gala , Santosh Shilimkar , Leo Li , "X.B. Xie" , "M.H. Lian" Subject: RE: [v12, 0/8] Fix eSDHC host version register bug Thread-Topic: [v12, 0/8] Fix eSDHC host version register bug Thread-Index: AQHSE9casinPeirj9EK8OzSRVU5haqCuMnoAgAED/2A= Date: Wed, 19 Oct 2016 02:40:53 +0000 Message-ID: References: <1474441040-11946-1-git-send-email-yangbo.lu@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yangbo.lu@nxp.com; x-originating-ip: [199.59.226.141] x-ms-office365-filtering-correlation-id: ecfd13c1-fb98-4a84-50da-08d3f7c958ba x-microsoft-exchange-diagnostics: 1;DB5PR04MB1190;7:bM15/kPbqsj7p5kbdjWY7ovycMooN1EVzIiE9bOfNuxWN80cHZs8zFar1nGYnymMksIX5xDbqbB4DuX9POjPIRqxtzgqbSdZ8mM/4o/DOIPFDos70hdo6wcx8R29w1IHvbA0guVi4iT17g6waYCk1OKccAv2Pq5sBViQCk0ifKdpkgEuF3hJMG7B6VmbRmPTPvIyxdOIIs7rrmMNX+pbtMdsGGK6/PRhyMCPYn4Xns5ZAiTpcz6G41W9N4Owc2yl7lraXl8bn5l7bYkEi/xRz4w9TXkWXhEH807sPrpX8bjMTEZck/2BfIKV02BQ2rDLjHESLpaQ/hPcOBt2txZw6kGwPbJXFiOXhSCddP7JMqc= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1190; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(65623756079841)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:DB5PR04MB1190;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1190; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(13464003)(199003)(377454003)(24454002)(87936001)(8936002)(81156014)(8676002)(19580395003)(97736004)(122556002)(81166006)(105586002)(305945005)(189998001)(7696004)(68736007)(9686002)(4326007)(5001770100001)(101416001)(86362001)(76576001)(2906002)(10400500002)(3660700001)(3846002)(586003)(19580405001)(7416002)(76176999)(50986999)(7846002)(11100500001)(5002640100001)(3280700002)(66066001)(102836003)(33656002)(106116001)(106356001)(54356999)(74316002)(92566002)(7736002)(77096005)(2950100002)(5660300001)(6116002)(2900100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR04MB1190;H:AM5PR0401MB2529.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2016 02:40:53.5431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1190 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9JFG25X017844 Content-Length: 4666 Lines: 98 > -----Original Message----- > From: Ulf Hansson [mailto:ulf.hansson@linaro.org] > Sent: Tuesday, October 18, 2016 6:48 PM > To: Y.B. Lu > Cc: linux-mmc; Scott Wood; Arnd Bergmann; linuxppc-dev@lists.ozlabs.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-clk; linux-i2c@vger.kernel.org; > iommu@lists.linux-foundation.org; netdev@vger.kernel.org; Mark Rutland; > Rob Herring; Russell King; Jochen Friedrich; Joerg Roedel; Claudiu Manoil; > Bhupesh Sharma; Qiang Zhao; Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > Xie; M.H. Lian > Subject: Re: [v12, 0/8] Fix eSDHC host version register bug > > On 21 September 2016 at 08:57, Yangbo Lu wrote: > > This patchset is used to fix a host version register bug in the > > T4240-R1.0-R2.0 eSDHC controller. To match the SoC version and > > revision, 10 previous version patchsets had tried many methods but all > of them were rejected by reviewers. > > Such as > > - dts compatible method > > - syscon method > > - ifdef PPC method > > - GUTS driver getting SVR method Anrd suggested a > > soc_device_match method in v10, and this is the only available method > > left now. This v11 patchset introduces the soc_device_match interface > > in soc driver. > > > > The first six patches of Yangbo are to add the GUTS driver. This is > > used to register a soc device which contain soc version and revision > information. > > The other two patches introduce the soc_device_match method in soc > > driver and apply it on esdhc driver to fix this bug. > > > > Arnd Bergmann (1): > > base: soc: introduce soc_device_match() interface > > > > Yangbo Lu (7): > > dt: bindings: update Freescale DCFG compatible > > ARM64: dts: ls2080a: add device configuration node > > dt: bindings: move guts devicetree doc out of powerpc directory > > powerpc/fsl: move mpc85xx.h to include/linux/fsl > > soc: fsl: add GUTS driver for QorIQ platforms > > MAINTAINERS: add entry for Freescale SoC drivers > > mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0 > > > > Documentation/devicetree/bindings/arm/fsl.txt | 6 +- > > .../bindings/{powerpc => soc}/fsl/guts.txt | 3 + > > MAINTAINERS | 11 +- > > arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 6 + > > arch/powerpc/kernel/cpu_setup_fsl_booke.S | 2 +- > > arch/powerpc/sysdev/fsl_pci.c | 2 +- > > drivers/base/Kconfig | 1 + > > drivers/base/soc.c | 66 ++++++ > > drivers/clk/clk-qoriq.c | 3 +- > > drivers/i2c/busses/i2c-mpc.c | 2 +- > > drivers/iommu/fsl_pamu.c | 3 +- > > drivers/mmc/host/Kconfig | 1 + > > drivers/mmc/host/sdhci-of-esdhc.c | 20 ++ > > drivers/net/ethernet/freescale/gianfar.c | 2 +- > > drivers/soc/Kconfig | 2 +- > > drivers/soc/fsl/Kconfig | 19 ++ > > drivers/soc/fsl/Makefile | 1 + > > drivers/soc/fsl/guts.c | 257 > +++++++++++++++++++++ > > include/linux/fsl/guts.h | 125 ++++++---- > > .../asm/mpc85xx.h => include/linux/fsl/svr.h | 4 +- > > include/linux/sys_soc.h | 3 + > > 21 files changed, 478 insertions(+), 61 deletions(-) rename > > Documentation/devicetree/bindings/{powerpc => soc}/fsl/guts.txt (91%) > > create mode 100644 drivers/soc/fsl/Kconfig create mode 100644 > > drivers/soc/fsl/guts.c rename arch/powerpc/include/asm/mpc85xx.h => > > include/linux/fsl/svr.h (97%) > > > > -- > > 2.1.0.27.g96db324 > > > > This looks good to me! I am not sure which tree you want this to be > picked up through, but unless no other volunteers I can take it through > my mmc tree. > > Although, before considering to apply, I need an ack from Scott/Arnd for > the guts driver in patch 5/8 and I need an ack from Greg for patch 7/8, > where the soc_device_match() interface is added (seems like you didn't > add him on cc/to). > [Lu Yangbo-B47093] Thanks a lot for your clarifying, Uffe. This patchset was based on mmc tree, and needed your picking up. But I think it needs to be rebased now since I saw qbman driver was in drivers/soc/fsl/ now. I will do that after collecting others' ACKs or comments. Hi Scott and Arnd, Could I get your ACTs if there're no other changes needed? Thanks a lot. > Kind regards > Uffe