Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945160AbcJSPbX (ORCPT ); Wed, 19 Oct 2016 11:31:23 -0400 Received: from vader.hardeman.nu ([95.142.160.32]:52956 "EHLO hardeman.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943167AbcJSPbU (ORCPT ); Wed, 19 Oct 2016 11:31:20 -0400 Mime-Version: 1.0 Date: Wed, 19 Oct 2016 13:03:45 +0000 Content-Type: text/plain; charset="utf-8" Message-ID: X-Mailer: RainLoop/1.10.3.151 From: "=?utf-8?B?RGF2aWQgSMOkcmRlbWFu?=" Subject: Re: [PATCH 1/5] [media] winbond-cir: Use kmalloc_array() in wbcir_tx() To: "SF Markus Elfring" , linux-media@vger.kernel.org, "Mauro Carvalho Chehab" , "Sean Young" Cc: "LKML" , kernel-janitors@vger.kernel.org, "Julia Lawall" In-Reply-To: <74b439c6-fa6f-1f78-424a-ebeb6c8bbb4f@users.sourceforge.net> References: <74b439c6-fa6f-1f78-424a-ebeb6c8bbb4f@users.sourceforge.net> <566ABCD9.1060404@users.sourceforge.net> <1d7d6a2c-0f1e-3434-9023-9eab25bb913f@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9JFVSMn018182 Content-Length: 1133 Lines: 36 October 14, 2016 1:41 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 07:19:00 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Sure...why not... Signed-off-by: David Härdeman > --- > drivers/media/rc/winbond-cir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c > index 95ae60e..59050f5 100644 > --- a/drivers/media/rc/winbond-cir.c > +++ b/drivers/media/rc/winbond-cir.c > @@ -660,7 +660,7 @@ wbcir_tx(struct rc_dev *dev, unsigned *b, unsigned count) > unsigned i; > unsigned long flags; > > - buf = kmalloc(count * sizeof(*b), GFP_KERNEL); > + buf = kmalloc_array(count, sizeof(*b), GFP_KERNEL); > if (!buf) > return -ENOMEM; > > -- > 2.10.1