Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754604AbcJSPpH (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Oct 2016 11:45:07 -0400
Received: from mail-lf0-f41.google.com ([209.85.215.41]:34416 "EHLO
        mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S942654AbcJSOfh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Oct 2016 10:35:37 -0400
Date: Wed, 19 Oct 2016 15:30:02 +0200
From: Johan Hovold <johan@kernel.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Alexandre Bailon <abailon@baylibre.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Wei Yongjun <weiyongjun1@huawei.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] greybus: es2: fix error return code in ap_probe()
Message-ID: <20161019133002.GK2765@localhost>
References: <1476883073-11370-1-git-send-email-weiyj.lk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1476883073-11370-1-git-send-email-weiyj.lk@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 550
Lines: 17

On Wed, Oct 19, 2016 at 01:17:53PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix to return a negative error code from the es2_arpc_in_enable() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for
> APBridgeA RPC")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Thanks for the fix. This was clearly broken and would have led to
havoc on disconnect as well.

Reviewed-by: Johan Hovold <johan@kernel.org>

Thanks,
Johan