Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755128AbcJSPtC (ORCPT ); Wed, 19 Oct 2016 11:49:02 -0400 Received: from vader.hardeman.nu ([95.142.160.32]:52887 "EHLO hardeman.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941981AbcJSO0U (ORCPT ); Wed, 19 Oct 2016 10:26:20 -0400 Mime-Version: 1.0 Date: Wed, 19 Oct 2016 13:47:43 +0000 Content-Type: text/plain; charset="utf-8" Message-ID: <10715e71c46bda76f6c8654675062f61@hardeman.nu> X-Mailer: RainLoop/1.10.3.151 From: "=?utf-8?B?RGF2aWQgSMOkcmRlbWFu?=" Subject: Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown() To: "SF Markus Elfring" , linux-media@vger.kernel.org Cc: "Mauro Carvalho Chehab" , "Sean Young" , "LKML" , kernel-janitors@vger.kernel.org, "Julia Lawall" In-Reply-To: <3c96d0bf-62fa-6b02-2a2d-2a097709271a@users.sourceforge.net> References: <3c96d0bf-62fa-6b02-2a2d-2a097709271a@users.sourceforge.net> <285954ec-280f-8a5a-5189-eb2471b4339c@users.sourceforge.net> <566ABCD9.1060404@users.sourceforge.net> <1d7d6a2c-0f1e-3434-9023-9eab25bb913f@users.sourceforge.net> <327f6034db9ce0c0a72947e47daf344a@hardeman.nu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9JFnFsJ018519 Content-Length: 608 Lines: 15 October 19, 2016 3:38 PM, "SF Markus Elfring" wrote: >>> Move the setting for the local variables "mask", "match" and "rc6_csl" >>> behind the source code for a condition check by this function >>> at the beginning. >> >> Again, I can't see what the point is? > > * How do you think about to set these variables only after the initial > check succeded? I prefer setting variables early so that no thinking about whether they're initialized or not is necessary later. > * Do you care for data access locality? Not unless you can show measurable performance improvements?