Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945797AbcJSPuy (ORCPT ); Wed, 19 Oct 2016 11:50:54 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:35201 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756903AbcJSOXv (ORCPT ); Wed, 19 Oct 2016 10:23:51 -0400 MIME-Version: 1.0 In-Reply-To: <1476883073-11370-1-git-send-email-weiyj.lk@gmail.com> References: <1476883073-11370-1-git-send-email-weiyj.lk@gmail.com> From: Viresh Kumar Date: Wed, 19 Oct 2016 19:37:19 +0530 X-Google-Sender-Auth: T8s20f1hYfezCuCKqsmk1-hPAmo Message-ID: Subject: Re: [PATCH -next] greybus: es2: fix error return code in ap_probe() To: Wei Yongjun Cc: Johan Hovold , Alex Elder , Alexandre Bailon , Greg Kroah-Hartman , driver-dev , Wei Yongjun , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 29 On Wed, Oct 19, 2016 at 6:47 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the es2_arpc_in_enable() error > handling case instead of 0, as done elsewhere in this function. > > Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for > APBridgeA RPC") > Signed-off-by: Wei Yongjun > --- > drivers/staging/greybus/es2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c > index 8eabc71..a97fccf 100644 > --- a/drivers/staging/greybus/es2.c > +++ b/drivers/staging/greybus/es2.c > @@ -1547,7 +1547,8 @@ static int ap_probe(struct usb_interface *interface, > INIT_LIST_HEAD(&es2->arpcs); > spin_lock_init(&es2->arpc_lock); > > - if (es2_arpc_in_enable(es2)) > + retval = es2_arpc_in_enable(es2); > + if (retval) > goto error; > > retval = gb_hd_add(hd); Acked-by: Viresh Kumar