Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941254AbcJSQXN (ORCPT ); Wed, 19 Oct 2016 12:23:13 -0400 Received: from mga03.intel.com ([134.134.136.65]:30265 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938790AbcJSOO6 (ORCPT ); Wed, 19 Oct 2016 10:14:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,514,1473145200"; d="scan'208";a="21673770" From: Jin Yao To: acme@kernel.org, jolsa@kernel.org Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@linux.intel.com Subject: [PATCH v2 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Date: Thu, 20 Oct 2016 06:01:11 +0800 Message-Id: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3839 Lines: 87 v2: Just a rebase to Arnaldo's perf/core branch, no functional changes. Initial post perf record -g -b ... perf report --branch-history Currently it only shows the branches from the LBR in the callgraph view. It would be useful to annotate branch predictions and TSX aborts and also timed LBR cycles also in the callgraph view. This would allow a quick overview where branch predictions are and how costly basic blocks are. For example: Overhead Source:Line Symbol Shared Object Predicted Abort Cycles ........ ............................................ ......... .............. ......... ..... ...... 38.25% div.c:45 [.] main div 97.6% 0.0% 3 | ---main div.c:42 (cycles:2) compute_flag div.c:28 (cycles:2) compute_flag div.c:27 (cycles:1) rand rand.c:28 (cycles:1) rand rand.c:28 (cycles:1) __random random.c:298 (cycles:1) __random random.c:297 (cycles:1) __random random.c:295 (cycles:1) __random random.c:295 (cycles:1) __random random.c:295 (cycles:1) __random random.c:295 (cycles:9) | |--36.73%--__random_r random_r.c:392 (cycles:9) | __random_r random_r.c:357 (cycles:1) | __random random.c:293 (cycles:1) | __random random.c:293 (cycles:1) | __random random.c:291 (cycles:1) | __random random.c:291 (cycles:1) | __random random.c:291 (cycles:1) | __random random.c:288 (cycles:1) | rand rand.c:27 (cycles:1) | rand rand.c:26 (cycles:1) | rand@plt +4194304 (cycles:1) | rand@plt +4194304 (cycles:1) | compute_flag div.c:25 (cycles:1) | compute_flag div.c:22 (cycles:1) | main div.c:40 (cycles:1) | main div.c:40 (cycles:16) | main div.c:39 (cycles:16) | | | |--29.93%--main div.c:39 (predicted:50.6%, cycles:1) | | main div.c:44 (predicted:50.6%, cycles:1) | | | | | --22.69%--main div.c:42 (cycles:2) Predicted is hide in callchain entry if the branch is 100% predicted. Abort is hide in callchain entry if the branch is 0 aborted. Now stdio and browser modes are both supported. Jin Yao (6): perf report: Add branch flag to callchain cursor node perf report: Caculate and return the branch counting in callchain perf report: Create a symbol_conf flag for showing branch flag counting perf report: Show branch info in callchain entry for stdio mode perf report: Show branch info in callchain entry for browser mode perf report: Display columns Predicted/Abort/Cycles in --branch-history tools/perf/Documentation/perf-report.txt | 8 ++ tools/perf/builtin-report.c | 9 +- tools/perf/ui/browsers/hists.c | 15 ++- tools/perf/ui/stdio/hist.c | 30 +++++- tools/perf/util/callchain.c | 176 ++++++++++++++++++++++++++++++- tools/perf/util/callchain.h | 16 ++- tools/perf/util/hist.c | 3 + tools/perf/util/hist.h | 3 + tools/perf/util/machine.c | 56 +++++++--- tools/perf/util/sort.c | 117 +++++++++++++++++++- tools/perf/util/sort.h | 3 + tools/perf/util/symbol.h | 1 + 12 files changed, 411 insertions(+), 26 deletions(-) -- 2.7.4