Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S946152AbcJSQZR (ORCPT ); Wed, 19 Oct 2016 12:25:17 -0400 Received: from mga03.intel.com ([134.134.136.65]:30265 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938870AbcJSOOx (ORCPT ); Wed, 19 Oct 2016 10:14:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,514,1473145200"; d="scan'208";a="21673824" From: Jin Yao To: acme@kernel.org, jolsa@kernel.org Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@linux.intel.com Subject: [PATCH v2 4/6] perf report: Show branch info in callchain entry for stdio mode Date: Thu, 20 Oct 2016 06:01:15 +0800 Message-Id: <1476914477-25420-5-git-send-email-yao.jin@linux.intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> References: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2955 Lines: 91 If the branch is 100% predicated then the "predicated" is hide. Similarly, if there is no branch tsx abort, the "abort" is hide. There is only cycles shown (cycle is supported on skylake platform, older platform would be 0). One example is: |--36.73%--__random_r random_r.c:392 (cycles:9) | __random_r random_r.c:357 (cycles:1) | __random random.c:293 (cycles:1) | __random random.c:293 (cycles:1) | __random random.c:291 (cycles:1) | __random random.c:291 (cycles:1) | __random random.c:291 (cycles:1) | __random random.c:288 (cycles:1) | rand rand.c:27 (cycles:1) | rand rand.c:26 (cycles:1) | rand@plt +4194304 (cycles:1) | rand@plt +4194304 (cycles:1) | compute_flag div.c:25 (cycles:1) | compute_flag div.c:22 (cycles:1) | main div.c:40 (cycles:1) | main div.c:40 (cycles:16) | main div.c:39 (cycles:16) | | | |--29.93%--main div.c:39 (predicted:50.6%, cycles:1) | | main div.c:44 (predicted:50.6%, cycles:1) Signed-off-by: Jin Yao --- tools/perf/ui/stdio/hist.c | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c index 89d8441..57e1f6f 100644 --- a/tools/perf/ui/stdio/hist.c +++ b/tools/perf/ui/stdio/hist.c @@ -41,7 +41,9 @@ static size_t ipchain__fprintf_graph(FILE *fp, struct callchain_node *node, { int i; size_t ret = 0; - char bf[1024]; + char bf[1024], *alloc_str = NULL; + char buf[64]; + const char *str; ret += callchain__fprintf_left_margin(fp, left_margin); for (i = 0; i < depth; i++) { @@ -56,8 +58,21 @@ static size_t ipchain__fprintf_graph(FILE *fp, struct callchain_node *node, } else ret += fprintf(fp, "%s", " "); } - fputs(callchain_list__sym_name(chain, bf, sizeof(bf), false), fp); + + str = callchain_list__sym_name(chain, bf, sizeof(bf), false); + + if (symbol_conf.show_branchflag_count) { + callchain_list_counts__printf_value(chain, NULL, + buf, sizeof(buf)); + if (asprintf(&alloc_str, "%s%s", str, buf) < 0) + str = "Not enough memory!"; + else + str = alloc_str; + } + + fputs(str, fp); fputc('\n', fp); + free(alloc_str); return ret; } @@ -219,8 +234,15 @@ static size_t callchain__fprintf_graph(FILE *fp, struct rb_root *root, } else ret += callchain__fprintf_left_margin(fp, left_margin); - ret += fprintf(fp, "%s\n", callchain_list__sym_name(chain, bf, sizeof(bf), - false)); + ret += fprintf(fp, "%s", + callchain_list__sym_name(chain, bf, + sizeof(bf), + false)); + + if (symbol_conf.show_branchflag_count) + ret += callchain_list_counts__printf_value( + chain, fp, NULL, 0); + ret += fprintf(fp, "\n"); if (++entries_printed == callchain_param.print_limit) break; -- 2.7.4