Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755972AbcJSQdE (ORCPT ); Wed, 19 Oct 2016 12:33:04 -0400 Received: from mail-qt0-f174.google.com ([209.85.216.174]:36008 "EHLO mail-qt0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753958AbcJSOLD (ORCPT ); Wed, 19 Oct 2016 10:11:03 -0400 From: Matt Fleming To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Matt Fleming , Ingo Molnar , Dietmar Eggemann , Paul Turner , Mike Galbraith Subject: [PATCH] sched/fair: Kill the unused sched_shares_window_ns tunable Date: Wed, 19 Oct 2016 15:10:59 +0100 Message-Id: <20161019141059.26408-1-matt@codeblueprint.co.uk> X-Mailer: git-send-email 2.10.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2290 Lines: 68 The last user of this tunable was removed in 2012 in commit 8295836 ("sched: Replace update_shares weight distribution with per-entity computation"). Delete it since its very existence confuses people. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Dietmar Eggemann Cc: Paul Turner Cc: Mike Galbraith Signed-off-by: Matt Fleming --- include/linux/sched/sysctl.h | 1 - kernel/sched/fair.c | 7 ------- kernel/sysctl.c | 7 ------- 3 files changed, 15 deletions(-) diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h index 22db1e63707e..441145351301 100644 --- a/include/linux/sched/sysctl.h +++ b/include/linux/sched/sysctl.h @@ -36,7 +36,6 @@ extern unsigned int sysctl_numa_balancing_scan_size; extern unsigned int sysctl_sched_migration_cost; extern unsigned int sysctl_sched_nr_migrate; extern unsigned int sysctl_sched_time_avg; -extern unsigned int sysctl_sched_shares_window; int sched_proc_update_handler(struct ctl_table *table, int write, void __user *buffer, size_t *length, diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 543b2f291152..f026050c15cc 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -93,13 +93,6 @@ unsigned int normalized_sysctl_sched_wakeup_granularity = 1000000UL; const_debug unsigned int sysctl_sched_migration_cost = 500000UL; -/* - * The exponential sliding window over which load is averaged for shares - * distribution. - * (default: 10msec) - */ -unsigned int __read_mostly sysctl_sched_shares_window = 10000000UL; - #ifdef CONFIG_CFS_BANDWIDTH /* * Amount of runtime to allocate from global (tg) to local (per-cfs_rq) pool diff --git a/kernel/sysctl.c b/kernel/sysctl.c index a13bbdaab47d..2a361dc6e1eb 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -347,13 +347,6 @@ static struct ctl_table kern_table[] = { .mode = 0644, .proc_handler = proc_dointvec, }, - { - .procname = "sched_shares_window_ns", - .data = &sysctl_sched_shares_window, - .maxlen = sizeof(unsigned int), - .mode = 0644, - .proc_handler = proc_dointvec, - }, #ifdef CONFIG_SCHEDSTATS { .procname = "sched_schedstats", -- 2.10.0