Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943582AbcJSRCp (ORCPT ); Wed, 19 Oct 2016 13:02:45 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:41777 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932277AbcJSRCn (ORCPT ); Wed, 19 Oct 2016 13:02:43 -0400 Subject: Re: [PATCH v2] ARC: Adjust cpuinfo for non-continuous cpu ids To: Noam Camus References: <1476876303-18768-1-git-send-email-noamca@mellanox.com> CC: "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Noam Camus From: Vineet Gupta Message-ID: <81c8e00d-2a78-d5ca-e75a-aeafbe3020cf@synopsys.com> Date: Wed, 19 Oct 2016 10:02:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476876303-18768-1-git-send-email-noamca@mellanox.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.41] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 42 On 10/19/2016 04:25 AM, Noam Camus wrote: > From: Noam Camus > > num_possible_cpus() returns how many CPUs may be present on system. > However we want the highest possible CPU number. > This may be differ in a sparsed possible CPUs map. > Such map achived by OF for plat-eznps. > > For example if we have: > possible cpus mask 0,3 > > Then: > num_possible_cpus() is equal 2 > while > nr_cpu_ids is equal 4. > > Only for value 4 c_start() will provide correct cpuinfo at procfs. This is much much better. Applied to for-curr ! Thx, -Vineet > > Signed-off-by: Noam Camus > --- > arch/arc/kernel/setup.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c > index 64907de..bd2e3a4 100644 > --- a/arch/arc/kernel/setup.c > +++ b/arch/arc/kernel/setup.c > @@ -512,7 +512,7 @@ static void *c_start(struct seq_file *m, loff_t *pos) > * way to pass it w/o having to kmalloc/free a 2 byte string. > * Encode cpu-id as 0xFFcccc, which is decoded by show routine. > */ > - return *pos < num_possible_cpus() ? cpu_to_ptr(*pos) : NULL; > + return *pos < nr_cpu_ids ? cpu_to_ptr(*pos) : NULL; > } > > static void *c_next(struct seq_file *m, void *v, loff_t *pos)