Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759445AbcJSRF6 (ORCPT ); Wed, 19 Oct 2016 13:05:58 -0400 Received: from mga06.intel.com ([134.134.136.31]:16210 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754418AbcJSRF4 (ORCPT ); Wed, 19 Oct 2016 13:05:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,367,1473145200"; d="scan'208";a="891714633" Message-ID: <1476896391.11323.509.camel@linux.intel.com> Subject: Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call From: Andy Shevchenko To: Ivan Safonov , Greg Kroah-Hartman , Bhaktipriya Shridhar , Geliang Tang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 19 Oct 2016 19:59:51 +0300 In-Reply-To: <1476896024.11323.506.camel@linux.intel.com> References: <1476889685-7367-1-git-send-email-insafonov@gmail.com> <1476889685-7367-2-git-send-email-insafonov@gmail.com> <1476896024.11323.506.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 50 On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote: > On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > > > > netdev_alloc_skb function > > already set dev member of pkt_copy. > > It might be one line. > > Some special references: > functions: function() > structs: struct my_struct > > P.S. Entire series lacks of cover letter. And couple more things:  - Use min percentage when run git format-patch to avoid inclusion non- maintainers / non-active developers  - Adjust your commit messages to be a bit more verbose and put explanation "why you create the patch" before "what is done in the patch". > > > > > > > Signed-off-by: Ivan Safonov > > --- > >  drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - > >  1 file changed, 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > > b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > > index 34198fe..f19b203 100644 > > --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > > +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > > @@ -123,7 +123,6 @@ static int recvbuf2recvframe(struct adapter > > *adapt, struct sk_buff *pskb) > >   > >   pkt_copy = netdev_alloc_skb(adapt->pnetdev, > > alloc_sz); > >   if (pkt_copy) { > > - pkt_copy->dev = adapt->pnetdev; > >   precvframe->pkt = pkt_copy; > >   precvframe->rx_head = pkt_copy->data; > >   precvframe->rx_end = pkt_copy->data + > > alloc_sz; > -- Andy Shevchenko Intel Finland Oy