Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943373AbcJSSIV (ORCPT ); Wed, 19 Oct 2016 14:08:21 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:34330 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757471AbcJSSIR (ORCPT ); Wed, 19 Oct 2016 14:08:17 -0400 Subject: Re: [PATCH v6 1/3] block: Add iocontext priority to request To: Tejun Heo , Adam Manzanares References: <1476728850-2309-1-git-send-email-adam.manzanares@hgst.com> <1476728850-2309-2-git-send-email-adam.manzanares@hgst.com> <20161019180524.GH18532@htj.duckdns.org> Cc: dan.j.williams@intel.com, hare@suse.de, martin.petersen@oracle.com, mchristi@redhat.com, toshi.kani@hpe.com, ming.lei@canonical.com, sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, Adam Manzananares From: Jens Axboe Message-ID: Date: Wed, 19 Oct 2016 12:08:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161019180524.GH18532@htj.duckdns.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 32 On 10/19/2016 12:05 PM, Tejun Heo wrote: > Hello, > > On Mon, Oct 17, 2016 at 11:27:28AM -0700, Adam Manzanares wrote: >> Patch adds an association between iocontext ioprio and the ioprio of a >> request. This is done to enable request based drivers the ability to >> act on priority information stored in the request. An example being >> ATA devices that support command priorities. If the ATA driver discovers >> that the device supports command priorities and the request has valid >> priority information indicating the request is high priority, then a high >> priority command can be sent to the device. This should improve tail >> latencies for high priority IO on any device that queues requests >> internally and can make use of the priority information stored in the >> request. >> >> The ioprio of the request is set in blk_rq_set_prio which takes the >> request and the ioc as arguments. If the ioc is valid in blk_rq_set_prio >> then the iopriority of the request is set as the iopriority of the ioc. >> In init_request_from_bio a check is made to see if the ioprio of the bio >> is valid and if so then the request prio comes from the bio. >> >> Signed-off-by: Adam Manzananares > > Jens, if you're okay with it, I can route this through > libata/for-4.10, or this can be applied to block and libata tree can > pull from it. I'm fine with that, add my Reviewed-by and funnel it through the libata tree. -- Jens Axboe