Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943231AbcJSTHW (ORCPT ); Wed, 19 Oct 2016 15:07:22 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:58043 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S942776AbcJSTHV (ORCPT ); Wed, 19 Oct 2016 15:07:21 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Wed, 19 Oct 2016 20:07:16 +0100 From: Chris Wilson To: Valentin Rothberg Cc: daniel.vetter@ffwll.ch, LKML Subject: Re: drm/i915: undefined STOP_MACHINE Message-ID: <20161019190716.GB19173@nuc-i3427.alporthouse.com> References: <20161019072635.GH29358@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161019072635.GH29358@nuc-i3427.alporthouse.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 26 On Wed, Oct 19, 2016 at 08:26:35AM +0100, Chris Wilson wrote: > On Wed, Oct 19, 2016 at 08:27:23AM +0200, Valentin Rothberg wrote: > > Dear Chris, > > > > your commit 9f267eb8d2ea ("drm/i915: Stop the machine whilst capturing > > the GPU crash dump") has popped up in today's linux-next and adds a > > select from DRM_I915 on STOP_MACHINE, which is not defined anywhere in > > Kconfig. > > > > STOP_MACHINE has been removed a while ago (see > > https://lkml.org/lkml/2015/11/19/133). I assume that HOTPLUG_CPU > > could be used? > > No. We don't need the select anymore as the core machinery now just > works without having to force compilation of the correct code. I completely forgot that we already had serialised with the STOP_MACHINE removal and had accidentally reintroduce the select in commit 9f267eb8d2ea ("drm/i915: Stop the machine whilst capturing the GPU crash dump") Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre