Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944898AbcJSTKu (ORCPT ); Wed, 19 Oct 2016 15:10:50 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59652 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbcJSTKt (ORCPT ); Wed, 19 Oct 2016 15:10:49 -0400 Date: Wed, 19 Oct 2016 15:10:47 -0400 (EDT) Message-Id: <20161019.151047.464176535089164279.davem@davemloft.net> To: peppe.cavallaro@st.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.torgue@st.com, rayagond@vayavyalabs.com, dan.carpenter@oracle.com, nico@linaro.org Subject: Re: [PATCH (net.git)] stmmac: fix and review the ptp registration. From: David Miller In-Reply-To: <1476860801-28242-1-git-send-email-peppe.cavallaro@st.com> References: <1476860801-28242-1-git-send-email-peppe.cavallaro@st.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Oct 2016 12:10:48 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 638 Lines: 16 From: Giuseppe Cavallaro Date: Wed, 19 Oct 2016 09:06:41 +0200 > The commit commit 7086605a6ab5 ("stmmac: fix error check when init ptp") > breaks the procedure added by the > commit efee95f42b5d ("ptp_clock: future-proofing drivers against PTP > subsystem becoming optional") > > So this patch tries to re-import the logic added by the latest > commit above: it makes sense to have the stmmac_ptp_register > as void function and, inside the main, the stmmac_init_ptp can fails > in case of the capability cannot be supported by the HW. > > Signed-off-by: Giuseppe Cavallaro Applied.