Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945049AbcJST2F (ORCPT ); Wed, 19 Oct 2016 15:28:05 -0400 Received: from mail.skyhub.de ([78.46.96.112]:55769 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933023AbcJST2E (ORCPT ); Wed, 19 Oct 2016 15:28:04 -0400 Date: Wed, 19 Oct 2016 21:28:01 +0200 From: Borislav Petkov To: Alexander Kuleshov Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Paolo Bonzini , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Message-ID: <20161019192801.imyce7ijsliikwk3@pd.tnic> References: <20161019191108.2230-1-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161019191108.2230-1-kuleshovmail@gmail.com> User-Agent: NeoMutt/ (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 32 On Thu, Oct 20, 2016 at 01:11:08AM +0600, Alexander Kuleshov wrote: > as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it. > > Signed-off-by: Alexander Kuleshov > --- > arch/x86/entry/calling.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h > index 9a9e588..b493c6a 100644 > --- a/arch/x86/entry/calling.h > +++ b/arch/x86/entry/calling.h > @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with > > #define SIZEOF_PTREGS 21*8 > > - .macro ALLOC_PT_GPREGS_ON_STACK addskip=0 > - addq $-(15*8+\addskip), %rsp > + .macro ALLOC_PT_GPREGS_ON_STACK > + addq $-(15*8), %rsp > .endm > > .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1 > -- Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.