Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761663AbcJSU03 (ORCPT ); Wed, 19 Oct 2016 16:26:29 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:46326 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754323AbcJSU01 (ORCPT ); Wed, 19 Oct 2016 16:26:27 -0400 Date: Wed, 19 Oct 2016 13:26:43 -0700 From: Darren Hart To: Azael Avalos Cc: "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" , carlos@strangeworlds.co.uk Subject: Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops Message-ID: <20161019202643.GB78689@f23x64.localdomain> References: <20160825185055.12143-1-coproscefalo@gmail.com> <20160828170037.GC96930@f23x64.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1240 Lines: 37 On Wed, Oct 12, 2016 at 10:26:43AM -0600, Azael Avalos wrote: > *ping* > > 2016-08-28 11:00 GMT-06:00 Darren Hart : > > On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote: > >> Bug 150611 uncovered that the WMI ID used by the toshiba-wmi driver > >> is not Toshiba specific, and as such, the driver was being loaded > >> on non Toshiba laptops too. > >> > >> This patch adds a DMI matching list checking for TOSHIBA as the > >> vendor, refusing to load if it is not. > >> > >> Also the WMI GUID was renamed, dropping the TOSHIBA_ prefix, to > >> better reflect that such GUID is not a Toshiba specific one. > >> > >> Cc: # 4.4+ > >> Signed-off-by: Azael Avalos > >> --- > >> Hi Darren, > >> > >> I was waiting on input from the bug above, but haven't received an > >> answer (as of yet), so I decided to send this to the mailing list > >> for feedback as to whether this is the correct approach for this > >> issue. > > > > Thanks. Let's see if Carlos (wmi.c author) has an opinion... > > > > Carlos? > > Any input on this? Looks like a sane workaround to me. Queued to fixes. Want to going to stable? -- Darren Hart Intel Open Source Technology Center