Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933687AbcJSUch (ORCPT ); Wed, 19 Oct 2016 16:32:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47827 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754640AbcJSUcc (ORCPT ); Wed, 19 Oct 2016 16:32:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 325FA61ADB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 19 Oct 2016 13:32:28 -0700 From: Stephen Boyd To: gabriel.fernandez@st.com Cc: Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Nicolas Pitre , Arnd Bergmann , daniel.thompson@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ludovic.barre@st.com, olivier.bideau@st.com, amelie.delaunay@st.com Subject: Re: [PATCH v2 5/6] clk: stm32f469: Add QSPI clock Message-ID: <20161019203228.GC8871@codeaurora.org> References: <1476436699-21879-1-git-send-email-gabriel.fernandez@st.com> <1476436699-21879-6-git-send-email-gabriel.fernandez@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476436699-21879-6-git-send-email-gabriel.fernandez@st.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1847 Lines: 61 On 10/14, gabriel.fernandez@st.com wrote: > @@ -532,10 +618,42 @@ static struct clk_hw *stm32_register_cclk(struct device *dev, const char *name, > { 0 }, > }; > > +struct stm32f4_clk_data { > + const struct stm32f4_gate_data *gates_data; > + const u64 *gates_map; > + int gates_num; > +}; > @@ -549,6 +667,19 @@ static void __init stm32f4_rcc_init(struct device_node *np) > goto fail; > } > > + match = of_match_node(stm32f4_of_match, np); > + if (WARN_ON(!match)) > + return; > + > + data = match->data; > + > + clks = kmalloc_array(data->gates_num + END_PRIMARY_CLK, > + sizeof(struct clk_hw *), GFP_KERNEL); sizeof(*clks)? > + if (!clks) > + goto fail; > + > + stm32f4_gate_map = data->gates_map; > + > hse_clk = of_clk_get_parent_name(np, 0); > > clk_register_fixed_rate_with_accuracy(NULL, "hsi", NULL, 0, > @@ -581,11 +712,15 @@ static void __init stm32f4_rcc_init(struct device_node *np) > clks[FCLK] = clk_hw_register_fixed_factor(NULL, "fclk", "ahb_div", > 0, 1, 1); > > - for (n = 0; n < ARRAY_SIZE(stm32f4_gates); n++) { > - const struct stm32f4_gate_data *gd = &stm32f4_gates[n]; > - unsigned int secondary = > - 8 * (gd->offset - STM32F4_RCC_AHB1ENR) + gd->bit_idx; > - int idx = stm32f4_rcc_lookup_clk_idx(0, secondary); > + for (n = 0; n < data->gates_num; n++) { > + const struct stm32f4_gate_data *gd; > + unsigned int secondary; > + int idx; > + > + gd = (struct stm32f4_gate_data *) &data->gates_data[n]; Why do we cast here? Get rid of const? Perhaps the struct shouldn't have const on the member instead? > + secondary = 8 * (gd->offset - STM32F4_RCC_AHB1ENR) + > + gd->bit_idx; > + idx = stm32f4_rcc_lookup_clk_idx(0, secondary); > > if (idx < 0) -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project