Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944354AbcJSUve (ORCPT ); Wed, 19 Oct 2016 16:51:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53106 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938152AbcJSUvc (ORCPT ); Wed, 19 Oct 2016 16:51:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 428C561716 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 19 Oct 2016 13:51:28 -0700 From: Stephen Boyd To: Robert Jarzmik Cc: Michael Turquette , "Rafael J. Wysocki" , Viresh Kumar , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq Message-ID: <20161019205128.GE8871@codeaurora.org> References: <1476130149-31834-1-git-send-email-robert.jarzmik@free.fr> <1476130149-31834-6-git-send-email-robert.jarzmik@free.fr> <87zim23zw3.fsf@belgarion.home> <20161018234855.GO8871@codeaurora.org> <877f943xjk.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877f943xjk.fsf@belgarion.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 49 On 10/19, Robert Jarzmik wrote: > Stephen Boyd writes: > > > On 10/18, Robert Jarzmik wrote: > >> Robert Jarzmik writes: > >> Hi Michael and Stephen, > >> > >> I'm planing on sending a v2 next week with minor corrections, mostly in the data > >> tables (pxa25x_freqs and pxa27x_freqs), as testing prooved some values were wrong. > >> > >> If you want me modify this serie, will you have time to review for next week or > >> should I delay the v2 posting ? > >> > > > > No need to delay. clk patches look fine with a quick glance. It > > would be really neat if we could make cpufreq-dt work without DT. > > What's blocking that? OPP tables? > > Heu I'm not the author of cpufreq-dt, so I'm not the best to answer. > To answer the question "without DT", it depends if you mean "with ACPI" or "with > platform_data" or something else. I mean platform_data mostly. Do you use ACPI with the clk driver? > > From what I've seen so far, the missing/blocking points are : > - the OPP points definition as you said Hm.. I thought cpufreq-dt worked with OPP tables populated by other code (i.e. platform code). > - probably same thing for the input power supply / regulator Regulators should be optional I hope. Do you use regulators in your design that has platform_data? > - the cooling parts probably > - and more generaly all the cpufreq-dt is built around device-tree > - last point, the name from KConfig, "Generic DT based cpufreq driver" > => that strongly suggest it's device-tree only > > I'm deeply convinced that Viresh being one of the authors will shed more light > on this. Sure, thanks for the notes. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project