Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755137AbcJSXb0 (ORCPT ); Wed, 19 Oct 2016 19:31:26 -0400 Received: from mail-vk0-f43.google.com ([209.85.213.43]:34027 "EHLO mail-vk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753630AbcJSXbY (ORCPT ); Wed, 19 Oct 2016 19:31:24 -0400 MIME-Version: 1.0 In-Reply-To: <1476901693-8492-3-git-send-email-mark.rutland@arm.com> References: <1476901693-8492-1-git-send-email-mark.rutland@arm.com> <1476901693-8492-3-git-send-email-mark.rutland@arm.com> From: Andy Lutomirski Date: Wed, 19 Oct 2016 16:31:02 -0700 Message-ID: Subject: Re: [PATCH 2/3] thread_info: factor out restart_block To: Mark Rutland Cc: "linux-kernel@vger.kernel.org" , linux-arch , Andrew Morton , Heiko Carstens , "H. Peter Anvin" , Kees Cook , Andrew Lutomirski , Ingo Molnar , Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 21 On Wed, Oct 19, 2016 at 11:28 AM, Mark Rutland wrote: > Since commit f56141e3e2d9aabf ("all arches, signal: move restart_block > to struct task_struct"), thread_info and restart_block have been > logically distinct, yet struct restart_block is still defined in > . > > At least one architecture (erroneously) uses restart_block as part of > its thread_info, and thus the definition of restart_block must come > before the include of . Subsequent patches in this > series need to shuffle the order of includes and definitions in > , and will make this ordering fragile. > > This patch moves the definition of restart_block out to its own header. > This serves as generic cleanup, logically separating thread_info and > restart_block, and also makes it easier to avoid fragility. Looks entirely reasonable to me. Reviewed-by: Andy Lutomirski --Andy