Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755631AbcJTHMo (ORCPT ); Thu, 20 Oct 2016 03:12:44 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:35759 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbcJTHMm (ORCPT ); Thu, 20 Oct 2016 03:12:42 -0400 Date: Thu, 20 Oct 2016 12:42:38 +0530 From: Viresh Kumar To: Masahiro Yamada Cc: linux-pm@vger.kernel.org, Stephen Boyd , linux-kernel@vger.kernel.org, Nishanth Menon , Len Brown , Greg Kroah-Hartman , "Rafael J. Wysocki" , Pavel Machek , Viresh Kumar Subject: Re: [PATCH v3] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus() Message-ID: <20161020071238.GN11766@vireshk-i7> References: <1476947569-23552-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476947569-23552-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 634 Lines: 24 On 20-10-16, 16:12, Masahiro Yamada wrote: > These log messages are wrong because _of_get_opp_desc_node() returns > an operating-points-v2 node. > > Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed > static checker warnings, and reworded the messages at the same time > (but the latter was not mentioned in the git-log). > > Restore the correct messages. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v3: > - Revive __func__ > > Changes in v2: > - Reword git-log slightly > comments -> log messages Acked-by: Viresh Kumar -- viresh