Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755631AbcJTICt (ORCPT ); Thu, 20 Oct 2016 04:02:49 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34102 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274AbcJTICq (ORCPT ); Thu, 20 Oct 2016 04:02:46 -0400 MIME-Version: 1.0 In-Reply-To: <410fd2c1-e841-cffb-51ba-cc4907c81203@rock-chips.com> References: <24daffe0-42a4-2a37-d685-7d9ecf9c3b11@rock-chips.com> <410fd2c1-e841-cffb-51ba-cc4907c81203@rock-chips.com> From: Tomeu Vizoso Date: Thu, 20 Oct 2016 10:02:22 +0200 X-Google-Sender-Auth: S5xj21CiHSBWaVjbI3GR7Jf7aEk Message-ID: Subject: Re: the dp helper would try to enable the i2c channel for rockchip-edp To: Randy Li Cc: "dri-devel@lists.freedesktop.org" , Daniel Vetter , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Gustavo Padovan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1602 Lines: 51 On 20 October 2016 at 09:38, Randy Li wrote: > > > On 10/20/2016 03:18 PM, Tomeu Vizoso wrote: >> >> On 19 October 2016 at 15:52, Randy Li wrote: >>> >>> Hello, >>> >>> Recently, I want to use a eDP panel in my RK3288 platform, but I got >>> the >>> following message: >>> >>> [ 8.935918] i2c i2c-6: of_i2c: modalias failure on /dp@ff970000/ports >>> [ 8.936018] rockchip-drm display-subsystem: bound ff970000.dp (ops >>> rockchip_dp_component_ops [analogix_dp_rockchip]) >>> It try to enable the eDP aux channel and add a new I2C controller, but it >>> failed then the whole display subsystem is broken, the panel doesn't >>> power >>> on either. >>> >>> I hope somebody could figure out what is wrong with it. >> >> >> Hi Randy, >> >> you want to debug why the call to of_modalias_node fails. >> > But I didn't know who register that I2C controller, as the system only have > 6 I2C controller(0-5). Ah, now I remember that the warning is spurious, have just sent a patch to avoid it with you on Cc ("ARM: dts: rockchip: add i2c-bus subnode to edp"). Could you please test it out? Regarding why a 7th I2C adapter is being registered, that's the one used by the eDP controller, and the code registering it is DRM core when the analogix driver calls drm_dp_aux_register. Regarding your problem with DRM not loading properly, you would need to attach more content from dmesg as the lines you attached doesn't seem related to it. You can get more debug logs from DRM by booting with this kernel parameter: drm.debug=0x1f Regards, Tomeu