Message-ID: <1476951388.21931.0.camel@perches.com>
Subject: Re: [PATCH] checkpatch: don't match against empty $const_structs
From: Joe Perches <joe@perches.com>
To: Jerome Forissier <jerome.forissier@linaro.org>,
        Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Date: Thu, 20 Oct 2016 01:16:28 -0700
In-Reply-To: <1476951126-30414-1-git-send-email-jerome.forissier@linaro.org>
References: <1476951126-30414-1-git-send-email-jerome.forissier@linaro.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 982
Lines: 29

On Thu, 2016-10-20 at 10:12 +0200, Jerome Forissier wrote:
> When $conststructsfile does not exist or is empty, we may get false
> warnings such as:
> WARNING: struct  should normally be const
> 
> Fix that by not running the string match if $const_structs is empty.

Why should $const_structs ever be empty?

> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..722a319 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6010,7 +6010,8 @@ sub process {
>  		}
>  
>  # check for various structs that are normally const (ops, kgdb, device_tree)
> -		if ($line !~ /\bconst\b/ &&
> +		if ($const_structs ne "" &&
> +		    $line !~ /\bconst\b/ &&
>  		    $line =~ /\bstruct\s+($const_structs)\b/) {
>  			WARN("CONST_STRUCT",
>  			     "struct $1 should normally be const\n" .
>