Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754429AbcJTIYC (ORCPT ); Thu, 20 Oct 2016 04:24:02 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:36267 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505AbcJTIYA (ORCPT ); Thu, 20 Oct 2016 04:24:00 -0400 MIME-Version: 1.0 In-Reply-To: <20161020082004.GU1041@n2100.armlinux.org.uk> References: <20161017065131.GA27863@angband.pl> <6556201.qTG4Pa4aHk@wuerfel> <3114442.xCAy34UQCk@wuerfel> <20161019153159.GQ1041@n2100.armlinux.org.uk> <20161020082004.GU1041@n2100.armlinux.org.uk> From: Geert Uytterhoeven Date: Thu, 20 Oct 2016 10:23:58 +0200 X-Google-Sender-Auth: qb46KuREvv_usEY3E38xcR9I8G8 Message-ID: Subject: Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM To: Russell King - ARM Linux Cc: Arnd Bergmann , Michal Marek , Nicholas Piggin , Adam Borowski , Omar Sandoval , Linus Torvalds , Alexey Dobriyan , Stephen Rothwell , Al Viro , linux-kbuild , "linux-kernel@vger.kernel.org" , Linux-Arch Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1621 Lines: 43 Hi Russell, On Thu, Oct 20, 2016 at 10:20 AM, Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 09:37:30AM +0200, Geert Uytterhoeven wrote: >> On Wed, Oct 19, 2016 at 5:32 PM, Russell King - ARM Linux >> wrote: >> > I'm not in favour of this. >> > >> > +extern void mmioset(void *, unsigned int, size_t); >> > +extern void mmiocpy(void *, const void *, size_t); >> > + >> > #ifndef __ARMBE__ >> > static inline void memset_io(volatile void __iomem *dst, unsigned c, >> > size_t count) >> > { >> > - extern void mmioset(void *, unsigned int, size_t); >> > mmioset((void __force *)dst, c, count); >> > } >> > >> > The reason they're declared _within_ memset_io() is to prevent people >> > from using them by hiding their declaration. Moving them outside is >> > an open invitation to stupid people starting to use them as an "oh it >> > must be an official API". >> >> If they're not intended for public use, they should (also) be prefixed >> with "__" or even "____" to make this clear. > > Tried that with the __cpuc_* cache flushing interfaces. It doesn't > have any effect what so ever. it may not stop the deliberate abuser, but it hints the casual reviewer. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds