Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934226AbcJTInr (ORCPT ); Thu, 20 Oct 2016 04:43:47 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:44807 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753536AbcJTInp (ORCPT ); Thu, 20 Oct 2016 04:43:45 -0400 Date: Thu, 20 Oct 2016 11:43:22 +0300 From: Dan Carpenter To: Ivan Safonov Cc: Greg Kroah-Hartman , Bhaktipriya Shridhar , Andy Shevchenko , Geliang Tang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/37] staging:r8188eu: remove skb cloning after netdev_alloc_skb fail Message-ID: <20161020084322.GN4469@mwanda> References: <1476889685-7367-1-git-send-email-insafonov@gmail.com> <1476889685-7367-3-git-send-email-insafonov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476889685-7367-3-git-send-email-insafonov@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 18 On Wed, Oct 19, 2016 at 10:07:31PM +0700, Ivan Safonov wrote: > In accordance with the KISS principle. > The changelog is not complete enough. Some people are going to read only the subject, but other people are only going to read the body of the changelog. They can be far apart depending on how you look at patches. For example: http://marc.info/?l=linux-driver-devel&m=147688960328996&w=2 It should say: "Just drop the packet if we can't allocate data. Don't go to a lot of work to try recover. Let the other side resend the data." regards, dan carpenter