Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755477AbcJTIrf (ORCPT ); Thu, 20 Oct 2016 04:47:35 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47518 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752323AbcJTIrb (ORCPT ); Thu, 20 Oct 2016 04:47:31 -0400 Date: Thu, 20 Oct 2016 11:46:36 +0300 From: Dan Carpenter To: Ivan Safonov Cc: Greg Kroah-Hartman , Bhaktipriya Shridhar , Andy Shevchenko , Geliang Tang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call Message-ID: <20161020084636.GO4469@mwanda> References: <1476889685-7367-1-git-send-email-insafonov@gmail.com> <1476889685-7367-2-git-send-email-insafonov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476889685-7367-2-git-send-email-insafonov@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 343 Lines: 11 On Wed, Oct 19, 2016 at 10:07:30PM +0700, Ivan Safonov wrote: > netdev_alloc_skb function > already set dev member of pkt_copy. > I'm coming back to this one after sending a response to patch 3. Here again, this patch was complicated for me to review because I mostly read the body of the email and not the subject. regards, dan carpenter