Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935645AbcJTI4y (ORCPT ); Thu, 20 Oct 2016 04:56:54 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:40893 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S935521AbcJTI4u (ORCPT ); Thu, 20 Oct 2016 04:56:50 -0400 From: James Liao To: Matthias Brugger , Sascha Hauer CC: Rob Herring , Kevin Hilman , Daniel Kurtz , , , , , , James Liao Subject: [PATCH v9 2/4] soc: mediatek: Init MT8173 scpsys driver earlier Date: Thu, 20 Oct 2016 16:56:36 +0800 Message-ID: <1476953798-23263-3-git-send-email-jamesjj.liao@mediatek.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1476953798-23263-1-git-send-email-jamesjj.liao@mediatek.com> References: <1476953798-23263-1-git-send-email-jamesjj.liao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1924 Lines: 52 Some power domain comsumers may init before module_init. So the power domain provider (scpsys) need to be initialized earlier too. Take an example for our IOMMU (M4U) and SMI. SMI is a bridge between IOMMU and multimedia HW. SMI is responsible to enable/disable iommu and help transfer data for each multimedia HW. Both of them have to wait until the power and clocks are enabled. So scpsys driver should be initialized before SMI, and SMI should be initialized before IOMMU, and then init IOMMU consumers (display/vdec/venc/camera etc.). IOMMU is subsys_init by default. So we need to init scpsys driver before subsys_init. Signed-off-by: James Liao Reviewed-by: Kevin Hilman --- drivers/soc/mediatek/mtk-scpsys.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c index fa9ee69..dd7a07d 100644 --- a/drivers/soc/mediatek/mtk-scpsys.c +++ b/drivers/soc/mediatek/mtk-scpsys.c @@ -613,4 +613,21 @@ static int scpsys_probe(struct platform_device *pdev) .of_match_table = of_match_ptr(of_scpsys_match_tbl), }, }; -builtin_platform_driver(scpsys_drv); + +static int __init scpsys_drv_init(void) +{ + return platform_driver_register(&scpsys_drv); +} + +/* + * There are some Mediatek drivers which depend on the power domain driver need + * to probe in earlier initcall levels. So scpsys driver also need to probe + * earlier. + * + * IOMMU(M4U) and SMI drivers for example. SMI is a bridge between IOMMU and + * multimedia HW. IOMMU depends on SMI, and SMI is a power domain consumer, + * so the proper probe sequence should be scpsys -> SMI -> IOMMU driver. + * IOMMU drivers are initialized during subsys_init by default, so we need to + * move SMI and scpsys drivers to subsys_init or earlier init levels. + */ +subsys_initcall(scpsys_drv_init); -- 1.9.1