Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758051AbcJTJMD (ORCPT ); Thu, 20 Oct 2016 05:12:03 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25502 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbcJTJMC (ORCPT ); Thu, 20 Oct 2016 05:12:02 -0400 Date: Thu, 20 Oct 2016 12:11:45 +0300 From: Dan Carpenter To: Ivan Safonov Cc: Greg Kroah-Hartman , Bhaktipriya Shridhar , Andy Shevchenko , Geliang Tang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 29/37] staging:r8188eu: take out stripping of iv and icv space from wlanhdr_to_ethhdr function Message-ID: <20161020091145.GQ4469@mwanda> References: <1476889685-7367-1-git-send-email-insafonov@gmail.com> <1476889685-7367-29-git-send-email-insafonov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476889685-7367-29-git-send-email-insafonov@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 476 Lines: 17 On Wed, Oct 19, 2016 at 10:07:57PM +0700, Ivan Safonov wrote: > @@ -1733,6 +1729,13 @@ static int recv_indicatepkts_in_order(struct adapter *padapter, struct recv_reor > return bPktInBuf; > } > > +void strip_iv_icv(struct sk_buff *skb, uint header_len, > + uint iv_len, uint icv_len) { Curly braces go down a line. > + memmove(skb->data + iv_len, skb->data, header_len); > + skb_pull(skb, iv_len); > + skb_trim(skb, skb->len - icv_len); > +} regards, dan carpenter