Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759368AbcJTKBI (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Oct 2016 06:01:08 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:47705 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1759174AbcJTKBG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Oct 2016 06:01:06 -0400
Date: Thu, 20 Oct 2016 11:57:03 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Bin Gao <bin.gao@linux.intel.com>
cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        John Stultz <john.stultz@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, bin.gao@intel.com
Subject: Re: [PATCH v3] x86/tsc: add X86_FEATURE_TSC_KNOWN_FREQ flag
In-Reply-To: <20161013231619.GA225074@worksta>
Message-ID: <alpine.DEB.2.20.1610201154020.5073@nanos>
References: <20160816174240.GA33372@worksta> <alpine.DEB.2.20.1608241049270.5714@nanos> <20160825164350.GA245186@worksta> <alpine.DEB.2.20.1608261210090.5714@nanos> <alpine.DEB.2.20.1608261212080.5714@nanos> <20161011211121.GA15041@worksta>
 <alpine.DEB.2.20.1610120948250.5032@nanos> <20161013231619.GA225074@worksta>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 617
Lines: 25

On Thu, 13 Oct 2016, Bin Gao wrote:
> @@ -702,6 +702,15 @@ unsigned long native_calibrate_tsc(void)
>  		}
>  	}
>  
> +	setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ);
> +
> +	/*
> +	 * For Atom SoCs TSC is the only reliable clocksource.
> +	 * Mark TSC reliable so no watchdog on it.
> +	 */
> +	if (boot_cpu_data.x86_model == INTEL_FAM6_ATOM_GOLDMONT)
> +		setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE);
> +

Right. That's what I wanted to see, but please split this into two patches:

  #1 Split the TSC flags
  #2 Set the flag for Goldmont

We do not mix design changes with hw support changes.

Thanks,

	tglx