Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756255AbcJTKot (ORCPT ); Thu, 20 Oct 2016 06:44:49 -0400 Received: from foss.arm.com ([217.140.101.70]:43844 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbcJTKos (ORCPT ); Thu, 20 Oct 2016 06:44:48 -0400 Date: Thu, 20 Oct 2016 11:44:18 +0100 From: Mark Rutland To: Peter Zijlstra Cc: Jan Glauber , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] Cavium ThunderX uncore PMU support Message-ID: <20161020104417.GD10234@leverpostej> References: <1476955841-27898-1-git-send-email-jglauber@cavium.com> <20161020103707.GB3175@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161020103707.GB3175@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 21 On Thu, Oct 20, 2016 at 12:37:07PM +0200, Peter Zijlstra wrote: > On Thu, Oct 20, 2016 at 11:30:36AM +0200, Jan Glauber wrote: > > Note: > > I'm using perf_sw_context in difference to perf_invalid_context > > (see WARN_ON in perf_pmu_register). Reason is that with perf_invalid_context > > add() is never called and the counter results are shown as "unsupported" by > > perf. With perf_sw_context everything works as expected. > > What?! All the uncore PMUs use perf_invalid_context. What doesn't work > for you? I think there's general confusion over the use of invalid context. Perhaps we could clear that up with: #define perf_uncore_context perf_invalid_context and s/perf_hw_context/perf_cpu_hw_context/ Mark.