Date: Thu, 20 Oct 2016 12:01:09 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jan Glauber <jglauber@cavium.com>, Will Deacon <will.deacon@arm.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/5] Cavium ThunderX uncore PMU support
Message-ID: <20161020110109.GE10234@leverpostej>
References: <1476955841-27898-1-git-send-email-jglauber@cavium.com>
 <20161020103707.GB3175@twins.programming.kicks-ass.net>
 <20161020104417.GD10234@leverpostej>
 <20161020105501.GU3102@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161020105501.GU3102@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 587
Lines: 22

On Thu, Oct 20, 2016 at 12:55:01PM +0200, Peter Zijlstra wrote:
> On Thu, Oct 20, 2016 at 11:44:18AM +0100, Mark Rutland wrote:
> > I think there's general confusion over the use of invalid context.
> > Perhaps we could clear that up with:
> > 
> > #define perf_uncore_context	perf_invalid_context
> > 
> > and
> > 
> > s/perf_hw_context/perf_cpu_hw_context/
> 
> What might be missing is the fact that these are _TASK_ contexts.

Yes, that too.

> New names might clarify things a little though.

I'll add that to the list of cleanup/rework I've been meaning to look
at.

Thanks,
Mark.