Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754332AbcJTL47 (ORCPT ); Thu, 20 Oct 2016 07:56:59 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:32871 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbcJTL46 (ORCPT ); Thu, 20 Oct 2016 07:56:58 -0400 Date: Thu, 20 Oct 2016 12:56:50 +0100 From: Peter Griffin To: Patrice Chotard Cc: linux-kernel@vger.kernel.org, Linus Walleij , linux-arm-kernel@lists.infradead.org, kernel@stlinux.com, lee.jones@linaro.org Subject: Re: [PATCH] pinctrl: st: don't specify default interrupt trigger Message-ID: <20161020115650.GA8848@griffinp-ThinkPad-X1-Carbon-2nd> References: <1476774988-13484-1-git-send-email-patrice.chotard@st.com> <729ebc94-5476-65a7-cc17-eabfba0d2404@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <729ebc94-5476-65a7-cc17-eabfba0d2404@st.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1240 Lines: 39 Hi Patrice, On Thu, 20 Oct 2016, Patrice Chotard wrote: > > > On 10/18/2016 09:16 AM, patrice.chotard@st.com wrote: > > From: Patrice Chotard > > > > Thanks to 332e99d5ae4 which now alerts of default > > trigger usage when configuring interrupts. > > > > Signed-off-by: Patrice Chotard > > --- > > drivers/pinctrl/pinctrl-st.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > > index 99da4cf..b7bb371 100644 > > --- a/drivers/pinctrl/pinctrl-st.c > > +++ b/drivers/pinctrl/pinctrl-st.c > > @@ -1512,7 +1512,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info, > > if (info->irqmux_base || gpio_irq > 0) { > > err = gpiochip_irqchip_add(&bank->gpio_chip, &st_gpio_irqchip, > > 0, handle_simple_irq, > > - IRQ_TYPE_LEVEL_LOW); > > + IRQ_TYPE_NONE); > > if (err) { > > gpiochip_remove(&bank->gpio_chip); > > dev_info(dev, "could not add irqchip\n"); > > > > Hi Linus > > I forgot to mention that this patch is dedicated for v4.9-rcs Wow, v4.9-rc is a noisy boot without this patch :) Acked-by: Peter Griffin